Skip to content

bootkube: remove apiserver --disable-phase-2 after default change#583

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sttts:sttts-remove-disable-phase-2-apiserver
Oct 31, 2018
Merged

bootkube: remove apiserver --disable-phase-2 after default change#583
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sttts:sttts-remove-disable-phase-2-apiserver

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Oct 31, 2018

Follow-up of openshift/cluster-kube-apiserver-operator#98 as the default changed and the flag is not necessary anymore.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2018
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 31, 2018

/assign @abhinavdahiya @soltysh

Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@openshift-merge-robot openshift-merge-robot merged commit 910c19a into openshift:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants