render: remove phase 2 by default#98
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 31, 2018
Merged
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
soltysh
approved these changes
Oct 31, 2018
|
|
||
| // TODO: remove when the installer has stopped using it | ||
| fs.BoolVar(&r.disablePhase2, "disable-phase-2", r.disablePhase2, "Disable rendering of the phase 2 daemonset and dependencies.") | ||
| fs.MarkHidden("disable-phase-2") |
Contributor
There was a problem hiding this comment.
You can remove that, MarkDeprecated does that.
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
sttts
force-pushed
the
sttts-remove-phase-2
branch
from
ebae22b to
9a70c9a
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns
--disable-phase-2into a no-op, to be removed when the installer stops using that flag.