Skip to content

bootkube: remove ctrl mgr --disable-phase-2 after default change#617

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sttts:sttts-remove-disable-phase-2-controller-manager
Nov 6, 2018
Merged

bootkube: remove ctrl mgr --disable-phase-2 after default change#617
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sttts:sttts-remove-disable-phase-2-controller-manager

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Nov 6, 2018

Clone of #583 for controller manager.

Follow-up of openshift/cluster-kube-controller-manager-operator#74 as the default changed and the flag is not necessary anymore.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2018
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Nov 6, 2018

/assign @abhinavdahiya

@abhinavdahiya
Copy link
Copy Markdown
Contributor

the tests are green, soo... 😇
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2018
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2973c9a into openshift:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants