Skip to content

bootkube: drop phase-2 for kube-controller-manager #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 2, 2018
Merged

bootkube: drop phase-2 for kube-controller-manager #580

openshift-merge-robot merged 1 commit into from
Nov 2, 2018
+3 −2

Conversation

@sttts
Copy link
Contributor

@sttts sttts commented Oct 31, 2018

This depends on openshift/cluster-kube-apiserver-operator#98 to be merged.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2018
soltysh
soltysh approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@sttts
Copy link
Contributor Author

sttts commented Oct 31, 2018

/retest

@sttts
Copy link
Contributor Author

sttts commented Oct 31, 2018

/assign @abhinavdahiya

@sttts
Copy link
Contributor Author

sttts commented Oct 31, 2018

/retest

abhinavdahiya
abhinavdahiya approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sttts
Copy link
Contributor Author

sttts commented Oct 31, 2018

@abhinavdahiya approved as well?

I guess CI has quota issues again. So we won't see this green soon.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 31, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 31, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 31, 2018

/hold

e2e-aws

Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Waiting for API at https://ci-op-jrlj8np4-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Another process exited
2018/10/31 22:10:38 Container test in pod e2e-aws failed, exit code 1, reason Error

is not a known flake, and this branch has never passed. Can you make sure it works and paste local success for these changes before we retest again ?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2018
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 31, 2018

/approve cancel

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Nov 1, 2018

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 1, 2018

There was an operator problem. It is now fixed.

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 1, 2018

/test e2e-aws

@sttts sttts mentioned this pull request Nov 1, 2018
Merged
@wking
Copy link
Member

wking commented Nov 1, 2018

e2e-aws API never came up:

Waiting for API at https://ci-op-9rykxpmg-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
Another process exited

@deads2k deads2k mentioned this pull request Nov 2, 2018
Closed
@sttts sttts force-pushed the sttts-controller-manage-disable-phase-2 branch from 097c6f0 to 02d75ee Compare November 2, 2018 08:45
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2018

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@sttts
Copy link
Contributor Author

sttts commented Nov 2, 2018 •
edited
Loading

Waiting for openshift/cluster-kube-controller-manager-operator#73 to merge which fixes the phase 3 controller manager by adding missing certs+keys. It was the reason that the ingress-operator service account did not get a token and hence the pod did not start up. Therefore, the e2e-aws test – which tests ingress – failed.

@sttts
Copy link
Contributor Author

sttts commented Nov 2, 2018

/retest

Images should be rebuilt by now.

@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 2, 2018
@deads2k
Copy link
Contributor

deads2k commented Nov 2, 2018 •
edited
Loading

simple rebase and now the other operators are working so it's green. retagging.

wking
wking reviewed Nov 2, 2018
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8be24fa into openshift:master Nov 2, 2018
@deads2k
Copy link
Contributor

deads2k commented Nov 2, 2018

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

+2 more reviewers

@soltysh soltysh soltysh approved these changes

@abhinavdahiya abhinavdahiya abhinavdahiya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@soltysh soltysh

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sttts @abhinavdahiya @openshift-merge-robot @mfojtik @deads2k @wking @openshift-ci-robot @soltysh