Skip to content

Conversation

@sttts
Copy link
Contributor

@sttts sttts commented Nov 1, 2018

Blocks #580.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 1, 2018
@sttts sttts force-pushed the sttts-proxy-checkpointer-kubeconfig branch from 22c2275 to bd5ee71 Compare November 1, 2018 19:23
@sttts
Copy link
Contributor Author

sttts commented Nov 1, 2018

/assign @deads2k @abhinavdahiya

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be base64 I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sttts sttts force-pushed the sttts-proxy-checkpointer-kubeconfig branch from bd5ee71 to 9234d06 Compare November 1, 2018 19:27
@abhinavdahiya
Copy link
Contributor

why are there so many secrets with same content? they can easily use one.
please add any new secrets to pkg/asset/manifests.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2018
@sttts sttts force-pushed the sttts-proxy-checkpointer-kubeconfig branch from 9234d06 to b99c2c4 Compare November 1, 2018 19:30
@sttts
Copy link
Contributor Author

sttts commented Nov 1, 2018

why are there so many secrets with same content? they can easily use one.
please add any new secrets to pkg/asset/manifests.

They are temporary as the other manifests in that go file. I don't want to make them more official than they are supposed to be. They are technical debt that needs to be addressed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know where this comes from? I would just as soon delete the entire checkpointer and not wait for that pod.

@sjenning same question.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am fine with deleting the checkpointer right away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased and removed all checkpointer code from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@squeed this is for you. What should we do here? The kube-proxy is temporary and is must be decoupled from the controller manager. Hence, this temporary file.

@sttts sttts force-pushed the sttts-proxy-checkpointer-kubeconfig branch from b99c2c4 to 2f1eb4c Compare November 1, 2018 21:54
@sttts
Copy link
Contributor Author

sttts commented Nov 1, 2018

Rebased onto #591.

@sttts sttts changed the title bootkube: decouple temporary proxy+checkpointer from controller manager phase 2 bootkube: decouple temporary kube-proxy from controller manager phase 2 Nov 1, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 1, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@wking
Copy link
Member

wking commented Nov 1, 2018

I dunno what the tf-fmt and tf-lint complaints are about. Maybe just a CI hiccup?

/test tf-fmt
/test tf-lint

name: kube-proxy-kubeconfig
namespace: kube-system
data:
kubeconfig: {{ .AdminKubeConfigBase64 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use the admin kubeconfig here (vs. the kubelet kubeconfig)? It may not be a big deal either way if we're going to drop this in the next week or so.

@openshift-merge-robot openshift-merge-robot merged commit 036c5ac into openshift:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants