-
Notifications
You must be signed in to change notification settings - Fork 1.5k
bootkube: decouple temporary kube-proxy from controller manager phase 2 #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootkube: decouple temporary kube-proxy from controller manager phase 2 #593
Conversation
22c2275 to
bd5ee71
Compare
|
/assign @deads2k @abhinavdahiya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be base64 I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
bd5ee71 to
9234d06
Compare
|
why are there so many secrets with same content? they can easily use one. /hold |
9234d06 to
b99c2c4
Compare
They are temporary as the other manifests in that go file. I don't want to make them more official than they are supposed to be. They are technical debt that needs to be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know where this comes from? I would just as soon delete the entire checkpointer and not wait for that pod.
@sjenning same question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am fine with deleting the checkpointer right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased and removed all checkpointer code from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@squeed this is for you. What should we do here? The kube-proxy is temporary and is must be decoupled from the controller manager. Hence, this temporary file.
b99c2c4 to
2f1eb4c
Compare
|
Rebased onto #591. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I dunno what the /test tf-fmt |
| name: kube-proxy-kubeconfig | ||
| namespace: kube-system | ||
| data: | ||
| kubeconfig: {{ .AdminKubeConfigBase64 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use the admin kubeconfig here (vs. the kubelet kubeconfig)? It may not be a big deal either way if we're going to drop this in the next week or so.
Blocks #580.