Add IBM Power VS: machine assets by clnperez · Pull Request #5611 · openshift/installer

clnperez · 2022-02-04T23:17:50Z

For more background on IPI on Power VS, refer to the enhancement
proposal here: openshift/enhancements#736

Older discussions on some of the code here can be found in #5224

Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

clnperez · 2022-02-22T19:23:45Z

@rna-afk does anyone else need eyes on the rest of these?

rna-afk · 2022-02-22T20:37:32Z

I cannot approve these PRs so I'll make sure to review it before I ask one of the team members to approve it.

clnperez · 2022-02-28T22:23:49Z

@rna-afk made all suggested changes

rna-afk · 2022-02-28T22:29:48Z

/lgtm
cc @staebler for approval

kirankt · 2022-02-28T23:19:21Z

Please re-verify vendoring.

clnperez · 2022-03-01T01:15:51Z

/test verify-vendor

staebler

Looks fine to me. I'll add my approve. I am removing the lgtm for my comment. @rna-afk, feel free to re-add the lgtm when the comment is addressed or an explained.
/approve
/lgtm cancel

clnperez · 2022-03-08T22:51:20Z

@patrickdillon assuming these tests all pass after #5612 merges, can either you or @staebler add your approve? it looks like Matthew's didn't take from his last comment.

rna-afk · 2022-03-08T23:33:23Z

Matthew already approved it so I will give an lgtm once #5612 passes

clnperez · 2022-03-09T21:29:32Z

There is no approve label though. Do we need one?

staebler

/approve

staebler · 2022-03-11T15:55:30Z

/lgtm

openshift-bot · 2022-03-11T16:03:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

staebler · 2022-03-11T16:30:13Z

verify-vendor is failing

/lgtm cancel

staebler · 2022-03-11T16:32:44Z

verify-vendor is failing

/lgtm cancel

github.com/openshift/installer/cmd/openshift-install imports
	github.com/openshift/library-go/pkg/config/clusteroperator/v1helpers loaded from github.com/openshift/library-go@v0.0.0-20210811133500-5e31383de2a7,
	but go 1.16 would select v0.0.0-20211214183058-58531ccbde67
github.com/openshift/installer/cmd/openshift-install imports
	github.com/openshift/library-go/pkg/route/routeapihelpers loaded from github.com/openshift/library-go@v0.0.0-20210811133500-5e31383de2a7,
	but go 1.16 would select v0.0.0-20211214183058-58531ccbde67

Update the go version used for verifying vendoring from 1.16 to 1.17. The CI job uses its own image and does not use the image specified in the script. Therefore, the go version in the script must match the go version in the CI job, particularly when there are breaking changes between go versions (as there are between 1.16 and 1.17 when it comes to modules).

For more background on IPI on Power VS, refer to the enhancement proposal here: openshift/enhancements#736 Older discussions on some of the code here can be found in openshift#5224 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

clnperez · 2022-03-15T18:42:35Z

I cherry-picked in #5709 and running ./verify-vendor.sh doesn't introduce any new changes, so I think as soon as that merges this will be good. It will just need a manual re-test.

staebler · 2022-03-15T20:32:04Z

Looks like go mod tidy is adamant about keeping this change now.

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

staebler · 2022-03-15T21:16:58Z

/lgtm
/approve

openshift-ci · 2022-03-15T21:18:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-03-15T23:35:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-15T23:52:21Z

@clnperez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel7	a5a89a0bcf8c5b044bd2a72d19bd22b3e5f68bdb	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-ibmcloud	`1608772`	link	false	`/test e2e-ibmcloud`
ci/prow/okd-e2e-aws-upgrade	`1608772`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-aws-fips	`1608772`	link	false	`/test e2e-aws-fips`
ci/prow/e2e-ovirt	`1608772`	link	false	`/test e2e-ovirt`
ci/prow/e2e-crc	`1608772`	link	false	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci Bot requested review from kirankt and patrickdillon February 4, 2022 23:18

rna-afk reviewed Feb 7, 2022

View reviewed changes

Comment thread pkg/asset/machines/powervs/machines.go Outdated

clnperez force-pushed the new-machine-assets branch from a5a89a0 to 81835bd Compare February 9, 2022 22:35

rna-afk reviewed Feb 9, 2022

View reviewed changes

Comment thread pkg/asset/machines/powervs/machinesets.go Outdated

mjturek mentioned this pull request Feb 15, 2022

Power VS: Add CIS CRN to Infrastructure manifest #5269

Closed

rna-afk reviewed Feb 22, 2022

View reviewed changes

Comment thread pkg/asset/machines/powervs/machines.go Outdated

Comment thread pkg/asset/machines/powervs/machines.go Outdated

Comment thread pkg/asset/machines/worker.go Outdated

clnperez force-pushed the new-machine-assets branch from 81835bd to ac9492f Compare February 28, 2022 22:23

clnperez force-pushed the new-machine-assets branch from ac9492f to a6e9ece Compare February 28, 2022 22:24

openshift-ci Bot assigned rna-afk Feb 28, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022

staebler reviewed Mar 1, 2022

View reviewed changes

Comment thread pkg/asset/machines/master.go Outdated

openshift-ci Bot assigned staebler Mar 1, 2022

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022

clnperez force-pushed the new-machine-assets branch from a6e9ece to 1caca8a Compare March 1, 2022 17:10

clnperez mentioned this pull request Mar 1, 2022

Add IBM Power VS: installconfig assets #5612

Merged

clnperez force-pushed the new-machine-assets branch 2 times, most recently from 0548afa to 28bda71 Compare March 4, 2022 00:58

staebler reviewed Mar 9, 2022

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022

clnperez force-pushed the new-machine-assets branch from 28bda71 to 315d985 Compare March 15, 2022 15:45

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022

clnperez force-pushed the new-machine-assets branch 2 times, most recently from fa1eee8 to 5844146 Compare March 15, 2022 16:27

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022

clnperez force-pushed the new-machine-assets branch from 5844146 to 7a192a3 Compare March 15, 2022 16:45

staebler and others added 2 commits March 15, 2022 14:22

Add IBM Power VS: machine assets

ec3d18f

For more background on IPI on Power VS, refer to the enhancement proposal here: openshift/enhancements#736 Older discussions on some of the code here can be found in openshift#5224 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

clnperez force-pushed the new-machine-assets branch from 7a192a3 to e0d70a9 Compare March 15, 2022 20:10

staebler force-pushed the new-machine-assets branch 2 times, most recently from a2e8b6f to ae2d4fa Compare March 15, 2022 20:30

staebler reviewed Mar 15, 2022

View reviewed changes

Power VS machine assets vendor

1608772

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

staebler force-pushed the new-machine-assets branch from ae2d4fa to 1608772 Compare March 15, 2022 20:45

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2022

openshift-merge-robot merged commit a4fa02e into openshift:master Mar 15, 2022

Conversation

clnperez commented Feb 4, 2022

Uh oh!

Uh oh!

Uh oh!

clnperez commented Feb 22, 2022

Uh oh!

rna-afk commented Feb 22, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clnperez commented Feb 28, 2022

Uh oh!

rna-afk commented Feb 28, 2022

Uh oh!

kirankt commented Feb 28, 2022

Uh oh!

clnperez commented Mar 1, 2022

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clnperez commented Mar 8, 2022

Uh oh!

rna-afk commented Mar 8, 2022

Uh oh!

clnperez commented Mar 9, 2022

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

staebler commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

staebler commented Mar 11, 2022

Uh oh!

staebler commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clnperez commented Mar 15, 2022

Uh oh!

staebler Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

staebler commented Mar 15, 2022

Uh oh!

openshift-ci Bot commented Mar 15, 2022

Uh oh!

openshift-bot commented Mar 15, 2022

Uh oh!

openshift-ci Bot commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

staebler commented Mar 11, 2022 •

edited

Loading