Skip to content

hack: update go version used in hack/verify-vendor.sh#5709

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
staebler:update_verify_vendor_go_version
Mar 15, 2022
Merged

hack: update go version used in hack/verify-vendor.sh#5709
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
staebler:update_verify_vendor_go_version

Conversation

@staebler
Copy link
Copy Markdown
Contributor

Update the go version used for verifying vendoring from 1.16 to 1.17. The CI job uses its own image and does not use the image specified in the script. Therefore, the go version in the script must match the go version in the CI job, particularly when there are breaking changes between go versions (as there are between 1.16 and 1.17 when it comes to modules).

Update the go version used for verifying vendoring from 1.16 to 1.17.
The CI job uses its own image and does not use the image specified
in the script. Therefore, the go version in the script must match
the go version in the CI job, particularly when there are breaking
changes between go versions (as there are between 1.16 and 1.17
when it comes to modules).
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from staebler after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2022

@staebler: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 75ac8ba link false /test e2e-libvirt
ci/prow/e2e-ibmcloud 75ac8ba link false /test e2e-ibmcloud
ci/prow/e2e-crc 75ac8ba link false /test e2e-crc
ci/prow/okd-e2e-aws-upgrade 75ac8ba link false /test okd-e2e-aws-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 75ac8ba link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/okd-e2e-aws 75ac8ba link false /test okd-e2e-aws
ci/prow/e2e-aws-upgrade 75ac8ba link true /test e2e-aws-upgrade
ci/prow/e2e-aws-single-node 75ac8ba link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 75ac8ba into openshift:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants