Add Nutanix-specific platform types #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 5 commits into openshift:master from nutanix-cloud-native:ntnx-2

Mar 16, 2022

Contributor

thunderboltsid commented Feb 3, 2022

Add types, defaults, and validations to support Nutanix platform on the Openshift installer.

thunderboltsid mentioned this pull request

Add Nutanix-specific platform types nutanix-cloud-native/openshift-installer#1

Closed

openshift-ci bot requested review from patrickdillon and rna-afk

February 3, 2022 16:10

openshift-ci bot added the do-not-merge/invalid-owners-file label

staebler reviewed

View reviewed changes

Contributor

staebler left a comment

Please separate vendor changes into their own commits, to make reviewing and perusing history easier.

pkg/types/nutanix/OWNERS Show resolved Hide resolved

pkg/types/nutanix/machinepool.go Outdated Show resolved Hide resolved

pkg/types/nutanix/machinepool.go Outdated Show resolved Hide resolved

pkg/types/nutanix/metadata.go Outdated Show resolved Hide resolved

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

go.mod Outdated Show resolved Hide resolved

pkg/types/nutanix/client.go Outdated Show resolved Hide resolved

openshift-ci bot added the needs-rebase label

thunderboltsid force-pushed the ntnx-2 branch 2 times, most recently from 8ee86f1 to 03322c6 Compare

February 10, 2022 20:40

openshift-ci bot removed the needs-rebase label

thunderboltsid force-pushed the ntnx-2 branch from 03322c6 to 1781efe Compare

February 11, 2022 11:54

openshift-ci bot removed the do-not-merge/invalid-owners-file label

thunderboltsid force-pushed the ntnx-2 branch from 1781efe to fcc2bde Compare

February 11, 2022 12:06

rvanderp3 reviewed

View reviewed changes

pkg/types/nutanix/platform.go Show resolved Hide resolved

rvanderp3 mentioned this pull request

Add nutanix-specific customizations to installconfig #5633

Merged

thunderboltsid force-pushed the ntnx-2 branch 2 times, most recently from 07b3d76 to da1f2f9 Compare

February 22, 2022 14:04

staebler reviewed

View reviewed changes

Contributor

staebler left a comment •

edited

Loading

Looks good except for a couple remaining nits.

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

pkg/types/nutanix/validation/platform.go Outdated Show resolved Hide resolved

Contributor

staebler commented Feb 23, 2022

There are some formatting errors.

INFO[2022-02-22T14:09:45Z] diff --git a/pkg/types/validation/installconfig_test.go b/pkg/types/validation/installconfig_test.go

And some unit test errors.

FAIL	github.com/openshift/installer/pkg/explain	0.083s

thunderboltsid force-pushed the ntnx-2 branch 2 times, most recently from d1d7a06 to ae974f6 Compare

February 24, 2022 16:28

openshift-ci bot added the needs-rebase label

thunderboltsid force-pushed the ntnx-2 branch from ae974f6 to 21e703b Compare

March 1, 2022 15:10

openshift-ci bot removed the needs-rebase label

Contributor Author

thunderboltsid commented Mar 1, 2022

/retest-required

Contributor

rvanderp3 commented Mar 14, 2022

/lgtm

openshift-ci bot assigned rvanderp3

openshift-ci bot added the lgtm label

staebler reviewed

View reviewed changes

Contributor

staebler left a comment

Just a small nit. Otherwise it looks good to me.
Feel free to re-apply the lgtm when the comment is addressed.
/approve
/lgtm cancel

pkg/types/machinepools.go Outdated Show resolved Hide resolved

openshift-ci bot assigned staebler

openshift-ci bot removed the lgtm label

Contributor

rvanderp3 commented Mar 15, 2022

/lgtm

openshift-ci bot added the lgtm label

Contributor

staebler commented Mar 15, 2022

/approve

Contributor

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

Contributor

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments

Contributor

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 15, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

thunderboltsid commented Mar 15, 2022

/test e2e-aws-upgrade

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

15 similar comments

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 16, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci bot commented Mar 16, 2022

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel7	`d450865`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/okd-e2e-aws	`06c7bc8`	link	false	`/test okd-e2e-aws`
ci/prow/okd-e2e-aws-upgrade	`06c7bc8`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-azure-upi	`06c7bc8`	link	false	`/test e2e-azure-upi`
ci/prow/e2e-ibmcloud	`06c7bc8`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-ovirt	`06c7bc8`	link	false	`/test e2e-ovirt`
ci/prow/e2e-crc	`06c7bc8`	link	false	`/test e2e-crc`
ci/prow/e2e-aws-fips	`06c7bc8`	link	false	`/test e2e-aws-fips`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 5366ddd into openshift:master

thunderboltsid deleted the ntnx-2 branch

May 25, 2022 07:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

patrickdillon Awaiting requested review from patrickdillon

rna-afk Awaiting requested review from rna-afk

3 more reviewers

vnephologist vnephologist left review comments

staebler staebler left review comments

rvanderp3 rvanderp3 left review comments

Labels