Add Nutanix-specific platform types #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2022
thunderboltsid
force-pushed
the
ntnx-1
branch
from
725cedd to
2af07de
Compare
thunderboltsid
force-pushed
the
ntnx-2
branch
from
3393a3f to
3f73619
Compare
Update openshift/api to include nutanix platform changes.
- Create the directory for nutanix specific types in pkg/types - Create the OWNERS file - Add Nutanix-specific structs i.e. MachinePool, Platform, Metadata, and OSDisk
This enables us to set defaults for nutanix later down the line.
Add validations and tests for validations in pkg/types/nutanix/validation.
Change disk size unit for nutanix platform from GiB to MiB.
- Change prism element from name to uuid - Change subnet from name to uuid
Add Nutanix v3 API client to pkg/types/nutanix
thunderboltsid
force-pushed
the
ntnx-2
branch
from
3f73619 to
d450865
Compare
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types, defaults, and validations to support Nutanix platform on the Openshift installer.
Note: This PR builds on top of a stopgap until openshift/api#1059 gets merged.