Skip to content

Add nutanix-specific customizations to installconfig #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 6, 2022
Merged

Add nutanix-specific customizations to installconfig #5633

openshift-merge-robot merged 1 commit into from
Apr 6, 2022

Conversation

@thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Feb 10, 2022

Add nutanix platform customizations in pkg/asset/installconfig.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 10, 2022
rvanderp3
rvanderp3 reviewed Feb 21, 2022
View reviewed changes
rvanderp3
rvanderp3 reviewed Feb 21, 2022
View reviewed changes
rvanderp3
rvanderp3 reviewed Feb 21, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 22, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@thunderboltsid thunderboltsid force-pushed the ntnx-5.1 branch 3 times, most recently from 1a9f22d to 0b10d8e Compare March 17, 2022 17:02
rvanderp3
rvanderp3 reviewed Mar 22, 2022
View reviewed changes
@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 23, 2022

/test all

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 24, 2022

/retest-required

rvanderp3
rvanderp3 reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@rvanderp3 rvanderp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a few nits, otherwise lgtm

@makentenza
Copy link
Contributor

makentenza commented Mar 28, 2022

/retest-required

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 28, 2022

/retest-required

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 29, 2022

/lgtm
/assign @staebler

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
staebler
staebler reviewed Mar 29, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 29, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 29, 2022

/retest-required

2 similar comments
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 30, 2022

/retest-required

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 30, 2022

/retest-required

staebler
staebler reviewed Mar 30, 2022
View reviewed changes
@thunderboltsid
Add nutanix-specific customizations to installconfig
8150c70 
Add nutanix platform customizations in pkg/asset/installconfig.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Mar 31, 2022

/retest-required

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-upi 1bcf337431228900d45bbdf50920ff44e96fc00e link false /test e2e-azure-upi
ci/prow/e2e-gcp-shared-vpc 8150c70 link false /test e2e-gcp-shared-vpc
ci/prow/e2e-openstack 8150c70 link false /test e2e-openstack
ci/prow/e2e-aws-disruptive 8150c70 link false /test e2e-aws-disruptive
ci/prow/e2e-ibmcloud 8150c70 link false /test e2e-ibmcloud
ci/prow/e2e-libvirt 8150c70 link false /test e2e-libvirt
ci/prow/e2e-metal-ipi-ovn-ipv6 8150c70 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-proxy 8150c70 link false /test e2e-aws-proxy
ci/prow/e2e-aws-single-node 8150c70 link false /test e2e-aws-single-node
ci/prow/e2e-azurestack 8150c70 link false /test e2e-azurestack
ci/prow/e2e-azure-resourcegroup 8150c70 link false /test e2e-azure-resourcegroup
ci/prow/e2e-ovirt 8150c70 link false /test e2e-ovirt
ci/prow/e2e-openstack-proxy 8150c70 link false /test e2e-openstack-proxy
ci/prow/e2e-crc 8150c70 link false /test e2e-crc
ci/prow/e2e-gcp-upi-xpn 8150c70 link false /test e2e-gcp-upi-xpn
ci/prow/e2e-openstack-parallel 8150c70 link false /test e2e-openstack-parallel
ci/prow/e2e-vsphere 8150c70 link false /test e2e-vsphere
ci/prow/e2e-azure 8150c70 link false /test e2e-azure
ci/prow/okd-e2e-aws-upgrade 8150c70 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-aws-upgrade 8150c70 link true /test e2e-aws-upgrade
ci/prow/e2e-gcp-upgrade 8150c70 link true /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Apr 1, 2022

/retest-required

1 similar comment
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Apr 4, 2022

/retest-required

staebler
staebler reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Apr 6, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Apr 6, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 93cd31a into openshift:master Apr 6, 2022
@thunderboltsid thunderboltsid deleted the ntnx-5.1 branch May 25, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rna-afk rna-afk Awaiting requested review from rna-afk

2 more reviewers

@staebler staebler staebler left review comments

@rvanderp3 rvanderp3 rvanderp3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@staebler staebler

@rvanderp3 rvanderp3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thunderboltsid @rvanderp3 @makentenza @openshift-bot @staebler @openshift-merge-robot