-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[BZ2038166] Add ShiftStack legacy certs script #40785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BZ2038166] Add ShiftStack legacy certs script #40785
Conversation
|
@pierreprinetti FYI This PR just has a new module at the moment--I haven't placed it in any docs assemblies, yet. |
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 7063dc8 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/620aa86a2630a000077933a7 😎 Browse the preview: https://deploy-preview-40785--osdocs.netlify.app |
|
TODO: Create 4.10 targeted PR for RN update |
4496a77 to
ca7fc75
Compare
|
Added mod to one existing assembly. I need to create a new OSP-specific update assembly that will contain solely this, too. |
|
This PR changes the script in the OpenShift upstream docs (it had syntax issues): openshift/installer#5576 |
|
@pierreprinetti 4e0d4ce adds your changes from openshift/installer#5576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a couple comments. One more thing that may or may not be interesting, is that users may look up the literal error that Go (and therefore operators) may return in the logs (see https://github.com/openshift/installer/blob/master/docs/user/openstack/known-issues.md#https-commonname-deprecation). You may or may not want to add it somewhere to help searches land on this page
Note that the error is returned if the user didn't prepare and actually upgrade while still using invalid certs.
I think this is a good idea. Will do. |
|
@itzikb-redhat Can you QE this re: BZ2038166? |
|
LGTM |
73349b4 to
827af6f
Compare
Resolves BZ2038166
77d1047 to
7063dc8
Compare
|
/cherry-pick enterprise-4.10 |
|
@maxwelldb: new pull request created: #41872 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Context: https://bugzilla.redhat.com/show_bug.cgi?id=2038166
Preview 1: https://deploy-preview-40785--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/preparing-to-install-on-openstack.html#security-osp-validating-certificates_preparing-to-install-on-openstack