Skip to content

Conversation

@maxwelldb maxwelldb added this to the Future Release milestone Jan 19, 2022
@maxwelldb maxwelldb self-assigned this Jan 19, 2022
@maxwelldb
Copy link
Contributor Author

@pierreprinetti FYI

This PR just has a new module at the moment--I haven't placed it in any docs assemblies, yet.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 7063dc8

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/620aa86a2630a000077933a7

😎 Browse the preview: https://deploy-preview-40785--osdocs.netlify.app

@maxwelldb
Copy link
Contributor Author

TODO: Create 4.10 targeted PR for RN update

@maxwelldb maxwelldb force-pushed the shiftstack-cert-validation-bz2038166 branch from 4496a77 to ca7fc75 Compare January 19, 2022 21:22
@maxwelldb
Copy link
Contributor Author

Added mod to one existing assembly. I need to create a new OSP-specific update assembly that will contain solely this, too.

@pierreprinetti
Copy link
Member

This PR changes the script in the OpenShift upstream docs (it had syntax issues): openshift/installer#5576

@maxwelldb
Copy link
Contributor Author

@pierreprinetti 4e0d4ce adds your changes from openshift/installer#5576

Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a couple comments. One more thing that may or may not be interesting, is that users may look up the literal error that Go (and therefore operators) may return in the logs (see https://github.com/openshift/installer/blob/master/docs/user/openstack/known-issues.md#https-commonname-deprecation). You may or may not want to add it somewhere to help searches land on this page

Note that the error is returned if the user didn't prepare and actually upgrade while still using invalid certs.

@maxwelldb
Copy link
Contributor Author

I have left a couple comments. One more thing that may or may not be interesting, is that users may look up the literal error that Go (and therefore operators) may return in the logs (see https://github.com/openshift/installer/blob/master/docs/user/openstack/known-issues.md#https-commonname-deprecation). You may or may not want to add it somewhere to help searches land on this page

Note that the error is returned if the user didn't prepare and actually upgrade while still using invalid certs.

I think this is a good idea. Will do.

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 10, 2022
@maxwelldb
Copy link
Contributor Author

@itzikb-redhat Can you QE this re: BZ2038166?

@itzikb-redhat
Copy link

LGTM

@maxwelldb maxwelldb force-pushed the shiftstack-cert-validation-bz2038166 branch from 73349b4 to 827af6f Compare February 14, 2022 14:44
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 14, 2022
@maxwelldb maxwelldb force-pushed the shiftstack-cert-validation-bz2038166 branch from 77d1047 to 7063dc8 Compare February 14, 2022 19:07
@maxwelldb maxwelldb merged commit e2b334f into openshift:main Feb 14, 2022
@maxwelldb maxwelldb deleted the shiftstack-cert-validation-bz2038166 branch February 14, 2022 19:10
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #41872

Details

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants