Skip to content

Bug 2038166: openstack: Document legacy HTTPS cert validation #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 18, 2022
Merged

Bug 2038166: openstack: Document legacy HTTPS cert validation #5544

openshift-merge-robot merged 1 commit into from
Jan 18, 2022

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jan 18, 2022

Provide a script to validate the OpenStack endpoints, to be run before
installing or upgrading to OpenShift v4.10.

/cc sdodson mandre s-urbaniak maxwelldb

@pierreprinetti
openstack: Document legacy HTTPS cert validation
32afc66 
Provide a script to validate the OpenStack endpoints, to be run before
installing or upgrading to OpenShift v4.10.
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@pierreprinetti: This pull request references Bugzilla bug 2038166, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

Bug 2038166: openstack: Document legacy HTTPS cert validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 18, 2022
@openshift-ci openshift-ci bot requested a review from eurijon January 18, 2022 09:48
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jan 18, 2022

Skip tests as this is a documentation patch.
/skip

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
mandre
mandre reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.
/lgtm

Also putting a hold for now to give other folks a chance to review.
/hold

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@EmilienM
Copy link
Member

EmilienM commented Jan 18, 2022

/hold cancel
/lgtm
/approve

excellent work

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 32afc66 link false /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel8 32afc66 link false /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ad535d3 into openshift:master Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 2038166 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2038166: openstack: Document legacy HTTPS cert validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jan 18, 2022

post merge but
/approve

@pierreprinetti pierreprinetti deleted the openstack-invalid-certs-doc branch January 19, 2022 08:20
@pierreprinetti pierreprinetti restored the openstack-invalid-certs-doc branch January 25, 2022 08:33
@pierreprinetti pierreprinetti deleted the openstack-invalid-certs-doc branch January 25, 2022 08:33
@openshift-ci openshift-ci bot mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb Awaiting requested review from maxwelldb

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@sdodson sdodson Awaiting requested review from sdodson

@eurijon eurijon Awaiting requested review from eurijon

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pierreprinetti @EmilienM @openshift-bot @sdodson @mandre @openshift-merge-robot