[wip] [vsphere] modify the cloud-config to support multiple datacenters#5356
Closed
rvanderp3 wants to merge 1 commit intoopenshift:masterfrom
Closed
[wip] [vsphere] modify the cloud-config to support multiple datacenters#5356rvanderp3 wants to merge 1 commit intoopenshift:masterfrom
rvanderp3 wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
rvanderp3
force-pushed
the
cloud-config-multiple-datacenters
branch
3 times, most recently
from
dda4b56 to
6af6727
Compare
openshift-ci
bot
added
the
needs-rebase
rvanderp3
force-pushed
the
cloud-config-multiple-datacenters
branch
from
6af6727 to
0279056
Compare
openshift-ci
bot
removed
the
needs-rebase
rvanderp3
force-pushed
the
cloud-config-multiple-datacenters
branch
2 times, most recently
from
e42f6e1 to
cf8d354
Compare
rvanderp3
force-pushed
the
cloud-config-multiple-datacenters
branch
from
cf8d354 to
3c31588
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@rvanderp3: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
closing in preference to #5911 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this PR is to configure the cloud-config to support multiple datacenters if configured appropriately in
install-config.yaml. See openshift/enhancements#918 for details.cc: @jcpowermac