[vsphere] support for multi-zone/region installation#5911
[vsphere] support for multi-zone/region installation#5911openshift-merge-robot merged 9 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
cc @jcpowermac |
rvanderp3
force-pushed
the
mcmd-platform
branch
8 times, most recently
from
07c2ef2 to
de29a70
Compare
rvanderp3
force-pushed
the
mcmd-platform
branch
17 times, most recently
from
ca39a4f to
3a1dbd0
Compare
There was a problem hiding this comment.
Hm I'm not sure about this. Two things:
- Don't both roles (
compute&master) go through this code path? So I suspect this would incorrectly fail if a zone withControlPlane == NotAllowedwere used for a compute machine pool. - I suspect this code should live in the machinepool validation code--not here.
There was a problem hiding this comment.
Machines is only used for rendering control plane nodes. Compute nodes are rendered from machinesets. I can look at pulling this in to the machinepool validation.
There was a problem hiding this comment.
its coming back to me now. at the point of machinepool validation, there isn't a readily available context indicating that a given pool is controlPlane or compute.
There was a problem hiding this comment.
oh ... wait, we know the pool name, and that is validated to ensure it matches controlPlane and compute pools.
There was a problem hiding this comment.
@patrickdillon changes have been committed which apply default zones based upon the machine pool role and what deploymentZones are defined.
rvanderp3
force-pushed
the
mcmd-platform
branch
from
34a5dfc to
203843d
Compare
openshift-merge-robot
added
the
needs-rebase
rvanderp3
force-pushed
the
mcmd-platform
branch
from
203843d to
1ed9b26
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
|
/retest |
implements the platform specification and associated validation to support vSphere multi-zone/region Implements openshift/enhancements#918
implements zone awareness and validation for associating machinepools with vSphere zone/region failure domains implements openshift/enhancements#918
assigns machines and machinesets to zones based upon machinepool definition implements openshift/enhancements#918
includes cloud-provider-vsphere to aid with (de)serialization of vSphere cloud-provider config resources implements openshift/enhancements#918
required to (un)marshall vSphere cloud provider structs properly implements openshift/enhancements#918
generates the out of tree cloud provider configuration when regions/zones are defined implements openshift/enhancements#918
enables the generation of vsphere-creds credential entries for multiple vCenters implements openshift/enhancements#918
rvanderp3
force-pushed
the
mcmd-platform
branch
from
1ed9b26 to
5cbd546
Compare
verifies that the vCenter resources defined for multi-zone/region failure domains exist implements openshift/enhancements#918
labels generated machine specs to enable terraform to properly target a machine to the desired zone/region implements openshift/enhancements#918
rvanderp3
force-pushed
the
mcmd-platform
branch
from
5cbd546 to
e94d5aa
Compare
|
/retest |
|
@rvanderp3: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
/skip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
6 participants
The intention of this PR is to implement the changes to the platform specification for vsphere as defined in openshift/enhancements#918