Skip to content

Comments

[vsphere] multi datacenter cluster machineset#5353

Closed
rvanderp3 wants to merge 1 commit intoopenshift:masterfrom
rvanderp3:multi-datacenter-cluster-machineset
Closed

[vsphere] multi datacenter cluster machineset#5353
rvanderp3 wants to merge 1 commit intoopenshift:masterfrom
rvanderp3:multi-datacenter-cluster-machineset

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Nov 3, 2021 •
edited
Loading

The intent of this PR is to create machines and machinesets for installation which honor configured zones and regions. For details please refer to openshift/enhancements#918.

This pull request depends on #5350, #5342, and #5347.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2021
@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 3, 2021

This one will need #5350 to merge first

@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 3, 2021

/test e2e-vsphere

/test e2e-vsphere-upi

@openshift-ci openshift-ci bot requested review from e-tienne and jhixson74 November 3, 2021 20:27
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Nov 3, 2021

This PR depends on #5342 and #5347 as well

@rvanderp3 rvanderp3 closed this Nov 4, 2021
@rvanderp3 rvanderp3 force-pushed the multi-datacenter-cluster-machineset branch from de35bb5 to 55b897f Compare November 4, 2021 13:05
@rvanderp3 rvanderp3 reopened this Nov 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign patrickdillon after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickdillon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign patrickdillon after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickdillon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvanderp3 rvanderp3 force-pushed the multi-datacenter-cluster-machineset branch 3 times, most recently from 11ba203 to ec8bcad Compare November 4, 2021 18:39
@rvanderp3 rvanderp3 mentioned this pull request Nov 4, 2021
Closed
@rvanderp3 rvanderp3 force-pushed the multi-datacenter-cluster-machineset branch 4 times, most recently from 5b2caf3 to de678a9 Compare November 5, 2021 16:38
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@rvanderp3 rvanderp3 force-pushed the multi-datacenter-cluster-machineset branch from de678a9 to e802ee6 Compare November 30, 2021 19:42
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2021
@rvanderp3 rvanderp3 changed the title [wip] [vsphere] multi datacenter cluster machineset [vsphere] multi datacenter cluster machineset Dec 1, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2021
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Dec 1, 2021

/hold

Placing hold pending merge of dependent PRs

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-upi c6c8353e7c99b9bbfd80d1840297f537a435ca71 link false /test e2e-vsphere-upi
ci/prow/e2e-vsphere c6c8353e7c99b9bbfd80d1840297f537a435ca71 link false /test e2e-vsphere
ci/prow/verify-vendor e802ee6 link true /test verify-vendor
ci/prow/govet e802ee6 link true /test govet
ci/prow/okd-unit e802ee6 link true /test okd-unit
ci/prow/unit e802ee6 link true /test unit
ci/prow/okd-images e802ee6 link true /test okd-images
ci/prow/e2e-aws-single-node e802ee6 link false /test e2e-aws-single-node
ci/prow/images e802ee6 link true /test images
ci/prow/e2e-aws-workers-rhel8 e802ee6 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-alibaba e802ee6 link true /test e2e-alibaba
ci/prow/e2e-aws e802ee6 link true /test e2e-aws
ci/prow/openstack-manifests e802ee6 link true /test openstack-manifests
ci/prow/e2e-aws-upgrade e802ee6 link true /test e2e-aws-upgrade
ci/prow/e2e-gcp-upgrade e802ee6 link true /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented May 26, 2022

closing in preference to #5911

@rvanderp3 rvanderp3 closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-tienne e-tienne Awaiting requested review from e-tienne

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rvanderp3 @jcpowermac