Azure Stack IPI Support #5084

patrickdillon · 2021-07-15T17:28:33Z

Adds Terraform configuration to build Azure Stack clusters. Successfully creates all infrastructure, but cluster bootstrapping depends on further upstream changes.

Currently marked as WIP because:

Need to revendor for OpenShift fork of Terraform Provider. That can happen now that this has been tested succesfully
Align Terraform configuration with new staged approach. We can begin this work now, but we may want to push that into a separate PR to allow parallel work.

This should unblock CI work in openshift/release#18796

patrickdillon · 2021-07-15T17:28:44Z

cc @rna-afk

patrickdillon · 2021-07-15T19:53:10Z

I have removed WIP from this. I would like to merge this soon to enable parallel work and we'll bring the multistages into a separate PR.

patrickdillon · 2021-07-19T14:02:49Z

Depends on #5032
Dependency is loose but #5032 looks very close to merge.
@rna-afk this was a pretty big rebase. hopefully it doesn't make your downstream changes too complicated. ash TF configs are in 8ccaee584bcbb99f7ef72444fc03705123899ff1

patrickdillon · 2021-07-19T14:04:35Z

I need to run another test to make sure bootstrap destroy works (which it did before switching to stages).

This is ready for review but I'm going to put a /hold until we get #5032 in or at least for today.
/hold

rna-afk

I think Matthew had 3 resources in his IPI work which had to be added to the terraform provider. The azurestack_image is added but the 2 others are missing. I can add those to the IPI work later or we could add them here if you like.

rna-afk · 2021-07-21T18:45:34Z

data/data/azurestack/bootstrap/main.tf

+  name                  = "ignition"
+  resource_group_name   = var.resource_group_name
+  storage_account_name  = var.storage_account.name
+  container_access_type = "blob"


Matthew had a comment that suggested setting container_access_type to "private" if the azurestack_storage_account_sas resource was available in terraform provider. I added this to the provider.

rna-afk · 2021-07-21T18:47:13Z

data/data/azurestack/vnet/nsg.tf

+  resource_group_name         = data.azurestack_resource_group.main.name
+  network_security_group_name = azurestack_network_security_group.cluster.name
+  description                 = local.description
+}


Matthew's work also included the azurestack_subnet_network_security_group_association which I added to the terraform provider.

rna-afk · 2021-07-21T19:03:32Z

/test e2e-azure

rna-afk · 2021-07-21T20:04:12Z

/lgtm

patrickdillon · 2021-07-22T15:39:32Z

/hold cancel
Azure PR is in merge pool.

patrickdillon · 2021-07-22T20:56:46Z

/hold

still waiting on #5032

patrickdillon · 2021-07-23T19:02:16Z

Still in the same state. I'm probably just being impatient.

openshift-ci · 2021-07-23T19:03:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhixson74,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Include the azurestack provider in the plugins that terraform knows.

Add the terraform files for provisioning a cluster in Azure Stack. Update Azure Stack TF to stages

Utilize the 2018-03-01 profile, which according to https://github.com/Azure/azure-sdk-for-go/blob/master/README.md is the latest hybrid profile. See https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-version-profiles?view=azs-2102#azure-api-profiles-and-azure-stack-hub-compatibility for more information on hybrid profiles.

Uses Azure Stack as the Terraform Provider for the Azure Stack platform. Follows the same stages as Azure, but uses the Azure Stack provider.

Uses SAS resource introduced in our provider fork to make bootstrap ignition private.

These tags mark DNS records as owned by the cluster, allowing them to be deleted.

Vendors the OpenShift fork of the Azure Stack Terraform provider and azure sdk.

rna-afk · 2021-07-23T22:10:05Z

/lgtm

patrickdillon · 2021-07-23T22:10:44Z

/lgtm
Rebased conflict

openshift-ci · 2021-07-23T22:10:45Z

@patrickdillon: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
Rebased conflict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2021-07-24T00:13:09Z

/skip

openshift-bot · 2021-07-24T00:38:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T03:26:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T04:02:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T04:38:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T04:50:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T07:38:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T08:39:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T08:51:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-24T14:22:57Z

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack-kuryr	`6fbadd4`	link	`/test e2e-openstack-kuryr`
ci/prow/e2e-ovirt	`6fbadd4`	link	`/test e2e-ovirt`
ci/prow/e2e-crc	`6fbadd4`	link	`/test e2e-crc`
ci/prow/e2e-libvirt	`6fbadd4`	link	`/test e2e-libvirt`
ci/prow/e2e-aws-workers-rhel7	`6fbadd4`	link	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-single-node	`6fbadd4`	link	`/test e2e-aws-single-node`
ci/prow/e2e-metal-single-node-live-iso	`6fbadd4`	link	`/test e2e-metal-single-node-live-iso`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-07-24T14:27:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T14:39:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021

openshift-ci bot requested review from fabianofranz and jhixson74 July 15, 2021 17:28

patrickdillon force-pushed the azurestack-ipi branch from 8e8250f to ad465c2 Compare July 15, 2021 19:39

patrickdillon changed the title ~~[WIP] Azure Stack IPI Support~~ Azure Stack IPI Support Jul 15, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021

patrickdillon force-pushed the azurestack-ipi branch from ad465c2 to 7110199 Compare July 19, 2021 13:58

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021

patrickdillon force-pushed the azurestack-ipi branch 5 times, most recently from 5297dcd to 81b466b Compare July 19, 2021 18:58

lobziik mentioned this pull request Jul 20, 2021

Azure Stack cloud provider config #5042

Merged

rna-afk reviewed Jul 21, 2021

View reviewed changes

openshift-ci bot assigned rna-afk Jul 21, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021

patrickdillon mentioned this pull request Jul 22, 2021

Azure Stack: Worker availability set #5102

Closed

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2021

patrickdillon force-pushed the azurestack-ipi branch from 81b466b to 919eada Compare July 22, 2021 20:55

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2021

openshift-ci bot assigned jhixson74 Jul 23, 2021

patrickdillon mentioned this pull request Jul 23, 2021

azurestackprivate Terraform Provider #5103

Closed

3 tasks

staebler and others added 7 commits July 23, 2021 18:03

terraform: add azurestack provider

de923a2

Include the azurestack provider in the plugins that terraform knows.

data: tf for azure stack

147edf2

Add the terraform files for provisioning a cluster in Azure Stack. Update Azure Stack TF to stages

Add Terraform Stages for Azure Stack

c96ce06

Uses Azure Stack as the Terraform Provider for the Azure Stack platform. Follows the same stages as Azure, but uses the Azure Stack provider.

Azure Stack TF: make bootstrap ignition private

20fd6ae

Uses SAS resource introduced in our provider fork to make bootstrap ignition private.

Azure Stack TF: add DNS tags

c7eb2f4

These tags mark DNS records as owned by the cluster, allowing them to be deleted.

Vendor: Azure Stack Dependencies

6fbadd4

Vendors the OpenShift fork of the Azure Stack Terraform provider and azure sdk.

patrickdillon force-pushed the azurestack-ipi branch from 13390fd to 6fbadd4 Compare July 23, 2021 22:07

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

openshift-merge-robot merged commit d88f1d2 into openshift:master Jul 24, 2021

Azure Stack IPI Support #5084

Azure Stack IPI Support #5084

Uh oh!

Conversation

patrickdillon commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickdillon commented Jul 15, 2021

Uh oh!

patrickdillon commented Jul 15, 2021

Uh oh!

patrickdillon commented Jul 19, 2021

Uh oh!

patrickdillon commented Jul 19, 2021

Uh oh!

rna-afk left a comment

Choose a reason for hiding this comment

Uh oh!

rna-afk Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rna-afk Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rna-afk commented Jul 21, 2021

Uh oh!

rna-afk commented Jul 21, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

rna-afk commented Jul 23, 2021

Uh oh!

patrickdillon commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

patrickdillon commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-ci bot commented Jul 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

patrickdillon commented Jul 15, 2021 •

edited

Loading

rna-afk Jul 21, 2021 •

edited

Loading

rna-afk Jul 21, 2021 •

edited

Loading

openshift-ci bot commented Jul 24, 2021 •

edited

Loading