Azure: Split terraform into stages #5032

jhixson74 · 2021-06-25T02:22:59Z

vnet: create permanent network resources
bootstrap: create bootstrap resources
cluster: create permanent cluster resources

This is needed for Terraform v0.14.6 and later since Terraform deletions now
destroy all resource dependencies.

https://issues.redhat.com/browse/CORS-1695

jhixson74 · 2021-06-25T02:24:26Z

/test e2e-azure

jhixson74 · 2021-06-25T02:59:40Z

/retest
/test e2e-azure

jhixson74 · 2021-06-28T18:11:23Z

/test e2e-azure

jhixson74 · 2021-06-30T22:46:25Z

/test e2e-azure

jhixson74 · 2021-07-01T04:44:42Z

/test e2e-azure

jhixson74 · 2021-07-01T23:21:31Z

/test e2e-azure

jhixson74 · 2021-07-08T16:45:31Z

/test e2e-azure

jhixson74 · 2021-07-08T17:22:40Z

/test e2e-azure

jhixson74 · 2021-07-14T05:12:51Z

/test e2e-azure

jhixson74 · 2021-07-14T07:48:35Z

/test e2e-azure

data/data/azure/cluster/main.tf

patrickdillon · 2021-07-19T14:25:20Z

We should get rid of all "Warning: Value for undeclared variable" messages by including them in the variable inputs for the modules. A quick search of CI logs turned up some, but there could be more:

time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="The root module does not declare a variable named \"public_lb_id\" but a value"
time="2021-07-14T16:23:46Z" level=debug msg="was found in file"
time="2021-07-14T16:23:46Z" level=debug msg="\"/tmp/openshift-install-bootstrap-197377047/vnet.tfvars.json\". To use this"
time="2021-07-14T16:23:46Z" level=debug msg="value, add a \"variable\" block to the configuration."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Using a variables file to set an undeclared variable is deprecated and will"
time="2021-07-14T16:23:46Z" level=debug msg="become an error in a future release. If you wish to provide certain \"global\""
time="2021-07-14T16:23:46Z" level=debug msg="settings to all configurations in your organization, use TF_VAR_..."
time="2021-07-14T16:23:46Z" level=debug msg="environment variables to set these instead."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Warning: Value for undeclared variable"
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="The root module does not declare a variable named \"public_lb_pip_v4_fqdn\" but"
time="2021-07-14T16:23:46Z" level=debug msg="a value was found in file"
time="2021-07-14T16:23:46Z" level=debug msg="\"/tmp/openshift-install-bootstrap-197377047/vnet.tfvars.json\". To use this"
time="2021-07-14T16:23:46Z" level=debug msg="value, add a \"variable\" block to the configuration."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Using a variables file to set an undeclared variable is deprecated and will"
time="2021-07-14T16:23:46Z" level=debug msg="become an error in a future release. If you wish to provide certain \"global\""
time="2021-07-14T16:23:46Z" level=debug msg="settings to all configurations in your organization, use TF_VAR_..."
time="2021-07-14T16:23:46Z" level=debug msg="environment variables to set these instead."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Warning: Value for undeclared variable"
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="The root module does not declare a variable named \"internal_lb_ip_v4_address\"

vnet: create permanent network resources bootstrap: create bootstrap resources cluster: create permanent cluster resources This is needed for Terraform v0.14.6 and later since Terraform deletions now destroy all resource dependencies. https://issues.redhat.com/browse/CORS-1695

jhixson74

We should get rid of all "Warning: Value for undeclared variable" messages by including them in the variable inputs for the modules. A quick search of CI logs turned up some, but there could be more:

time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="The root module does not declare a variable named \"public_lb_id\" but a value"
time="2021-07-14T16:23:46Z" level=debug msg="was found in file"
time="2021-07-14T16:23:46Z" level=debug msg="\"/tmp/openshift-install-bootstrap-197377047/vnet.tfvars.json\". To use this"
time="2021-07-14T16:23:46Z" level=debug msg="value, add a \"variable\" block to the configuration."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Using a variables file to set an undeclared variable is deprecated and will"
time="2021-07-14T16:23:46Z" level=debug msg="become an error in a future release. If you wish to provide certain \"global\""
time="2021-07-14T16:23:46Z" level=debug msg="settings to all configurations in your organization, use TF_VAR_..."
time="2021-07-14T16:23:46Z" level=debug msg="environment variables to set these instead."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Warning: Value for undeclared variable"
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="The root module does not declare a variable named \"public_lb_pip_v4_fqdn\" but"
time="2021-07-14T16:23:46Z" level=debug msg="a value was found in file"
time="2021-07-14T16:23:46Z" level=debug msg="\"/tmp/openshift-install-bootstrap-197377047/vnet.tfvars.json\". To use this"
time="2021-07-14T16:23:46Z" level=debug msg="value, add a \"variable\" block to the configuration."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Using a variables file to set an undeclared variable is deprecated and will"
time="2021-07-14T16:23:46Z" level=debug msg="become an error in a future release. If you wish to provide certain \"global\""
time="2021-07-14T16:23:46Z" level=debug msg="settings to all configurations in your organization, use TF_VAR_..."
time="2021-07-14T16:23:46Z" level=debug msg="environment variables to set these instead."
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="Warning: Value for undeclared variable"
time="2021-07-14T16:23:46Z" level=debug
time="2021-07-14T16:23:46Z" level=debug msg="The root module does not declare a variable named \"internal_lb_ip_v4_address\"

Removing cluster/vnet probably fixes this.

jhixson74 · 2021-07-20T17:37:12Z

/test e2e-azure

patrickdillon · 2021-07-22T02:33:32Z

/test e2e-azure

patrickdillon · 2021-07-22T13:57:22Z

/lgtm
/approve

openshift-ci · 2021-07-22T13:57:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-22T14:42:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T15:06:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T15:18:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T15:43:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T16:08:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T16:44:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T16:56:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-22T17:08:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

patrickdillon · 2021-07-22T17:19:54Z

/skip

patrickdillon · 2021-07-22T17:30:45Z

/retest-required

patrickdillon · 2021-07-22T18:53:08Z

/retest-required

patrickdillon · 2021-07-22T22:07:44Z

/retest-required

openshift-bot · 2021-07-22T22:50:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-22T23:20:35Z

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack-kuryr	`f80acc2`	link	`/test e2e-openstack-kuryr`
ci/prow/e2e-libvirt	`f80acc2`	link	`/test e2e-libvirt`
ci/prow/e2e-crc	`f80acc2`	link	`/test e2e-crc`
ci/prow/e2e-metal-ipi-ovn-ipv6	`f80acc2`	link	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-aws-workers-rhel7	`f80acc2`	link	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

patrickdillon · 2021-07-23T01:14:55Z

/retest-required

openshift-bot · 2021-07-23T01:52:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2021

openshift-ci bot requested review from e-tienne and m1kola June 25, 2021 02:23

jhixson74 force-pushed the master_terraform_split_azure branch from af78e33 to 5b4dad8 Compare June 25, 2021 02:24

jhixson74 force-pushed the master_terraform_split_azure branch from 5b4dad8 to ce4573b Compare June 28, 2021 18:10

jhixson74 force-pushed the master_terraform_split_azure branch 3 times, most recently from 31a1df3 to 024e6a9 Compare June 30, 2021 22:45

jhixson74 force-pushed the master_terraform_split_azure branch from 024e6a9 to 1c65892 Compare July 1, 2021 04:44

jhixson74 force-pushed the master_terraform_split_azure branch from 1c65892 to bad669c Compare July 1, 2021 22:36

jhixson74 force-pushed the master_terraform_split_azure branch from bad669c to e19e7cb Compare July 8, 2021 16:45

jhixson74 force-pushed the master_terraform_split_azure branch from e19e7cb to 27c1134 Compare July 8, 2021 17:22

jhixson74 changed the title ~~WIP: Split Azure Terraform~~ Split Azure Terraform into stages Jul 8, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2021

jhixson74 force-pushed the master_terraform_split_azure branch from 27c1134 to 8db1fa4 Compare July 14, 2021 05:12

jhixson74 changed the title ~~Split Azure Terraform into stages~~ WIP: Split Azure Terraform into stages Jul 14, 2021

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2021

jhixson74 force-pushed the master_terraform_split_azure branch 2 times, most recently from 2b8e6e8 to a49bfcc Compare July 14, 2021 07:48

jhixson74 force-pushed the master_terraform_split_azure branch from a49bfcc to 498dfe6 Compare July 14, 2021 14:27

patrickdillon reviewed Jul 18, 2021

View reviewed changes

data/data/azure/cluster/main.tf Outdated Show resolved Hide resolved

patrickdillon mentioned this pull request Jul 19, 2021

Azure Stack IPI Support #5084

Merged

2 tasks

jhixson74 force-pushed the master_terraform_split_azure branch from 498dfe6 to f80acc2 Compare July 20, 2021 17:06

jhixson74 commented Jul 20, 2021

View reviewed changes

openshift-ci bot assigned patrickdillon Jul 22, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021

openshift-merge-robot merged commit 6f0d506 into openshift:master Jul 23, 2021

Azure: Split terraform into stages #5032

Azure: Split terraform into stages #5032

Uh oh!

Conversation

jhixson74 commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhixson74 commented Jun 25, 2021

Uh oh!

jhixson74 commented Jun 25, 2021

Uh oh!

jhixson74 commented Jun 28, 2021

Uh oh!

jhixson74 commented Jun 30, 2021

Uh oh!

jhixson74 commented Jul 1, 2021

Uh oh!

jhixson74 commented Jul 1, 2021

Uh oh!

jhixson74 commented Jul 8, 2021

Uh oh!

jhixson74 commented Jul 8, 2021

Uh oh!

jhixson74 commented Jul 14, 2021

Uh oh!

jhixson74 commented Jul 14, 2021

Uh oh!

Uh oh!

patrickdillon commented Jul 19, 2021

Uh oh!

jhixson74 left a comment

Choose a reason for hiding this comment

Uh oh!

jhixson74 commented Jul 20, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

openshift-ci bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

patrickdillon commented Jul 22, 2021

Uh oh!

openshift-bot commented Jul 22, 2021

Uh oh!

openshift-ci bot commented Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickdillon commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jhixson74 commented Jun 25, 2021 •

edited

Loading

openshift-ci bot commented Jul 22, 2021 •

edited

Loading