Azure Stack: Worker availability set #5102
Conversation
Include the azurestack provider in the plugins that terraform knows.
vnet: create permanent network resources bootstrap: create bootstrap resources cluster: create permanent cluster resources This is needed for Terraform v0.14.6 and later since Terraform deletions now destroy all resource dependencies. https://issues.redhat.com/browse/CORS-1695
Add the terraform files for provisioning a cluster in Azure Stack. Update Azure Stack TF to stages
Vendors the OpenShift fork of the Azure Stack Terraform provider.
Utilize the 2018-03-01 profile, which according to https://github.com/Azure/azure-sdk-for-go/blob/master/README.md is the latest hybrid profile. See https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-version-profiles?view=azs-2102#azure-api-profiles-and-azure-stack-hub-compatibility for more information on hybrid profiles.
Uses Azure Stack as the Terraform Provider for the Azure Stack platform. Follows the same stages as Azure, but uses the Azure Stack provider.
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
patrickdillon
changed the title
patrickdillon
force-pushed
the
worker-availability-set
branch
from
9f459c5 to
d59d743
Compare
|
@patrickdillon |
This creates a worker availability set for use by the Machine API Operator.
patrickdillon
force-pushed
the
worker-availability-set
branch
from
d59d743 to
0406764
Compare
As I mentioned in the description, we have not decided if we are going forward with this approach, so it is probably best to wait. This PR would enable the creation of workers, so ensuring workers are created would indicate success. I think you may be confusing availability zones (do not exist in ASH) with availability sets (the topic of this PR). |
|
@patrickdillon: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@patrickdillon: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
The Azure provider is throwing an error when trying to create worker machines outside of an availability set. The machine api operator does not have the ability to create availability sets, so the installer must create one for worker nodes.
0406764 is the significant commit, while the rest of the PR is built on top of #5084
/hold
This is meant to enable the cloud team to test as a PoC while we determine the best way forward.
If we are to move forward with the installer creating this resource for the MAO, we will need to establish some API interface such as a field in the the machine(set) spec.