installer/pkg/config-generator/tls: Don't Sprintf string literals #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
openshift-ci-robot
added
needs-ok-to-test
Contributor
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
Both of these lines were touched by ae41b0a (Merge pull request openshift#22 from trawler/kube_tls_certs, 2018-07-09), but there's no need to use Sprintf to inject string literals into the format template. 26930f2 (post-review fixes, 2018-07-07, openshift#22) fixed one such instance, but left these. The * instance dates back to bf61dc9 (installer/pkg/config-generator/tls: generate ingress certs, 2018-07-06, openshift#16).
wking
force-pushed
the
sprintf-string-literals
branch
from
0e14846 to
3650e3d
Compare
Member
Author
|
Similar 31 errors in the e2e-aws tests as we saw here: The difference is EOF (this time) vs. TLS handshake timeout (in #46). |
Contributor
|
/test e2e-aws |
Member
Author
|
The two e2e-aws failures look like these. |
Contributor
|
/retest |
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Update owners file with addition of asalkeld
mkumatag
pushed a commit
to mkumatag/installer
that referenced
this pull request
Aug 17, 2021
Deprecation warnings are currently thrown because of quoted references to the ibm.vpc and ibm.powervs providers. The reccomendation since terraform 0.12.14 is to remove any quotations. [0] [0] https://discuss.hashicorp.com/t/terraform-0-12-14-released/389
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Sep 2, 2021
Deprecation warnings are currently thrown because of quoted references to the ibm.vpc and ibm.powervs providers. The reccomendation since terraform 0.12.14 is to remove any quotations. [0] [0] https://discuss.hashicorp.com/t/terraform-0-12-14-released/389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these lines were touched by ae41b0a (#22), but there's no need to use
Sprintfto inject string literals into the format template. 26930f2 (#22) fixed one such instance, but left these. The*instance dates back to bf61dc9 (#16).