installer/pkg/config-generator/tls: generate ingress certs #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
squat
approved these changes
Jul 6, 2018
Contributor
|
/lgtm |
Contributor
|
/lgtm |
spangenberg
approved these changes
Jul 6, 2018
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 10, 2018
Both of these lines were touched by ae41b0a (Merge pull request openshift#22 from trawler/kube_tls_certs, 2018-07-09), but there's no need to use Sprintf to inject string literals into the format template. 26930f2 (post-review fixes, 2018-07-07, openshift#22) fixed one such instance, but left these. The * instance dates back to bf61dc9 (installer/pkg/config-generator/tls: generate ingress certs, 2018-07-06, openshift#16).
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Apr 30, 2019
Integrate coredns with the mdns plugin
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Allow ClusterOperator to be set to Degraded state
clnperez
added a commit
to clnperez/installer
that referenced
this pull request
Jul 2, 2021
add infrastructure asset and revendor Signed-off-by: Christy Norman <[email protected]>
clnperez
added a commit
to clnperez/installer
that referenced
this pull request
Jul 16, 2021
add infrastructure asset and revendor Signed-off-by: Christy Norman <[email protected]>
clnperez
added a commit
to clnperez/installer
that referenced
this pull request
Jul 20, 2021
add infrastructure asset and revendor Signed-off-by: Christy Norman <[email protected]>
clnperez
added a commit
to clnperez/installer
that referenced
this pull request
Jul 22, 2021
add infrastructure asset and revendor Signed-off-by: Christy Norman <[email protected]>
clnperez
added a commit
to clnperez/installer
that referenced
this pull request
Sep 2, 2021
add infrastructure asset and revendor Signed-off-by: Christy Norman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.