Skip to content

Conversation

@flaper87
Copy link
Contributor

@flaper87 flaper87 commented Oct 6, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2018
@wking
Copy link
Member

wking commented Oct 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2f42f8a into openshift:master Oct 7, 2018
@flaper87
Copy link
Contributor Author

flaper87 commented Oct 8, 2018

@russellb @hardys @tomassedovic FYI, you should all have review/merge powers on the OpenStack bits in this repo.

@tomassedovic
Copy link
Contributor

This is fantastic. Thanks!

wking added a commit to wking/openshift-installer that referenced this pull request Apr 9, 2020
This seems to be a relic of 619db92 (pkg/types/config: Break into
pkg/validate and pkg/tfvars, 2018-10-03, openshift#412) and 5192edd (Add
OpenStack OWNERS, 2018-10-06, openshift#428) coming in close proximity.
vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Apr 13, 2020
This seems to be a relic of 619db92 (pkg/types/config: Break into
pkg/validate and pkg/tfvars, 2018-10-03, openshift#412) and 5192edd (Add
OpenStack OWNERS, 2018-10-06, openshift#428) coming in close proximity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants