pkg/types/config: Break into pkg/validate and pkg/tfvars

[wking]

Builds on #403; I'll rebase after that lands.

This removes a few Cluster properties which are no longer used by the new installer. It also drops YAML loading for Cluster now that it's a one-way map from InstallConfig to Terraform JSON. I've shifted validation into its own package, since we should be validating these at the InstallConfig level.

I've dropped the old Cluster (and subtype) specific validation. We'll want to add InstallConfig validation once we support loading it from the disk, but for now we can rely on the UserProvided validation (and this commit was already large enough ;).

[abhinavdahiya]

Can we not create a new package that has types. we already have pkg/types. maybe just a new file.

[wking]

Can we not create a new package that has types. we already have pkg/types.

We already have types all over:

$ git describe
v0.1.0-30-ge4c8898
$ for DIR in pkg/*; do echo -n "${DIR} "; git grep '^type ' "${DIR}" | wc -l; done
pkg/asset 72
pkg/destroy 5
pkg/ipnet 1
pkg/rhcos 0
pkg/terraform 1
pkg/types 50

My impression was that pkg/types was going to be for external consumers who wanted to use something we were pushing into the cluster (e.g. InstallConfig). And that ideally, pkg/types would have very minimal external dependencies or dynamic code outside of the type definitions themselves. This roughly corresponds to our current docs for the package.

The new pkg/tfvars has an internal type, but its public API is just the one function, which nobody except for us is likely to care about. If my understanding of pkg/types scoping is accurate, then the TFVars function does not qualify for pkg/types inclusion.

[abhinavdahiya]

/approve

[wking]

Rebased onto master and green.

[abhinavdahiya]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment