Skip to content

pkg/types/config: Remove unused directory #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 10, 2020
Merged

pkg/types/config: Remove unused directory #3438

openshift-merge-robot merged 1 commit into from
Apr 10, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Apr 9, 2020

This seems to be a relic of 619db92 (#412) and 5192edd (#428) coming in close proximity.

@wking
pkg/types/config: Remove unused directory
5fb1833 
This seems to be a relic of 619db92 (pkg/types/config: Break into
pkg/validate and pkg/tfvars, 2018-10-03, openshift#412) and 5192edd (Add
OpenStack OWNERS, 2018-10-06, openshift#428) coming in close proximity.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 10, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 5fb1833 link /test e2e-ovirt
ci/prow/e2e-openstack 5fb1833 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 5fb1833 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt 5fb1833 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Apr 10, 2020

/lgtm

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Apr 10, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit c64dc6c into openshift:master Apr 10, 2020
@wking wking deleted the drop-empty-openstack-directory branch April 15, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @openshift-ci-robot @abhinavdahiya @openshift-merge-robot