Skip to content

Conversation

@crawford
Copy link
Contributor

These are no longer referenced now their consumers have been removed.

Continuing from #339.

With the introduction of the new installer core, all of these assets are
created by the installer instead of Terraform.
These are no longer referenced now their consumers have been removed.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2018
@wking
Copy link
Member

wking commented Sep 27, 2018

The images failure is:

warning: Could not load current user information: user: unknown userid 1150070000
Unable to connect to the server: net/http: TLS handshake timeout

Dunno what that's about.

@crawford
Copy link
Contributor Author

/retest images

@crawford
Copy link
Contributor Author

/test images

@crawford
Copy link
Contributor Author

/retest

@crawford
Copy link
Contributor Author

/hold

I think I can delete a few more resources.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2018
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link
Contributor Author

/hold cancel

Looks like they are removed in #342.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2018
@openshift-merge-robot openshift-merge-robot merged commit b88ce1b into openshift:master Sep 28, 2018
@crawford crawford deleted the terraform branch September 28, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants