Skip to content

Conversation

@crawford
Copy link
Contributor

The new installer generates handles many of these assets directly.

With the introduction of the new installer core, all of these assets are
created by the installer instead of Terraform.
These are no longer referenced now their consumers have been removed.
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2018
@crawford
Copy link
Contributor Author

/hold

Tested locally, but let's wait for CI to be enabled.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2018
@wking
Copy link
Member

wking commented Sep 26, 2018

/lgtm

We can pull the hold once openshift/release#1677 lands.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Sep 26, 2018

Also low-hanging fruit in this vein is removing WORKSPACE, all the BUILD.bazel, installer/cmd, everything under installer/pkg except installer/pkg/validate (which is used by pkg/types/config/validate.go and pkg/asset/installconfig/ssh.go), and reverting 2ac5913.

@crawford
Copy link
Contributor Author

Also low-hanging fruit in this vein is removing all...

I've got that in another set of commits. I could put that up for review as well.

@wking
Copy link
Member

wking commented Sep 27, 2018

/retest

@wking
Copy link
Member

wking commented Sep 27, 2018

/refresh

Or something, now that we are (hopefully temporarily) outside of smoke-test coverage.

@wking
Copy link
Member

wking commented Sep 27, 2018

Maybe just:

/test all

@crawford
Copy link
Contributor Author

/refresh

@crawford
Copy link
Contributor Author

/skip

@crawford
Copy link
Contributor Author

crawford commented Sep 27, 2018

/override e2e-aws-smoke

I'm overriding the e2e-aws-smoke test because it no longer exists as of openshift/release#1677. This is a stale status.

EDIT: This was worth a shot.

@crawford crawford closed this Sep 27, 2018
@crawford crawford reopened this Sep 27, 2018
@crawford crawford closed this Sep 27, 2018
@crawford crawford deleted the terraform branch September 27, 2018 23:32
@openshift-ci-robot
Copy link
Contributor

@crawford: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-smoke 00dcbf6 link /test e2e-aws-smoke
ci/prow/e2e-aws 00dcbf6 link /test e2e-aws
ci/prow/yaml-lint 00dcbf6 link /test yaml-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants