-
Notifications
You must be signed in to change notification settings - Fork 1.5k
data/*: remove unneeded terraform templates #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the introduction of the new installer core, all of these assets are created by the installer instead of Terraform.
These are no longer referenced now their consumers have been removed.
|
/hold Tested locally, but let's wait for CI to be enabled. |
|
/lgtm We can pull the hold once openshift/release#1677 lands. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Also low-hanging fruit in this vein is removing |
I've got that in another set of commits. I could put that up for review as well. |
|
/retest |
|
/refresh Or something, now that we are (hopefully temporarily) outside of smoke-test coverage. |
|
Maybe just: /test all |
|
/refresh |
|
/skip |
|
/override e2e-aws-smoke I'm overriding the e2e-aws-smoke test because it no longer exists as of openshift/release#1677. This is a stale status. EDIT: This was worth a shot. |
|
@crawford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The new installer generates handles many of these assets directly.