Skip to content

Wrap all errors with context #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 4, 2018
Merged

Wrap all errors with context #400

openshift-merge-robot merged 2 commits into from
Oct 4, 2018

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Oct 3, 2018

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 3, 2018
@wking
Copy link
Member

wking commented Oct 3, 2018

Looks good to me, but your unit tests are failing.

@abhinavdahiya abhinavdahiya force-pushed the wrap_errors branch 3 times, most recently from 19bf9fa to b6fda54 Compare October 3, 2018 05:47
wking
wking reviewed Oct 3, 2018
View reviewed changes
wking
wking reviewed Oct 3, 2018
View reviewed changes
wking
wking reviewed Oct 3, 2018
View reviewed changes
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Oct 3, 2018

DRY'ed up userprovided errors as per suggestion of @wking eff2fdc

@wking
Copy link
Member

wking commented Oct 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 3, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking wking mentioned this pull request Oct 4, 2018
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Oct 4, 2018

/hold

Waiting on #415 to unstick CI.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2018
@wking
Copy link
Member

wking commented Oct 4, 2018

#415 is in.

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2018
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Oct 4, 2018

e2e-aws

2018/10/04 18:47:36 Copying artifacts from release-latest into /logs/artifacts/release-latest
info: Using registry public hostname registry.svc.ci.openshift.org
info: Found 77 images in image stream
info: Manifests will be extracted to /tmp/release-image-2018-10-04T184721Z004777864
warning: Could not load current user information: user: unknown userid 1008410000
Unable to connect to the server: net/http: TLS handshake timeout
2018/10/04 18:47:36 Container release in pod release-latest failed, exit code 1, reason Error
2018/10/04 18:47:43 Ran for 10m42s
error: could not run steps: failed to wait for release pod to complete: could not wait for pod completion: the pod ci-op-r1r0kmj0/release-latest failed after 1m4s (failed containers: release):  unknown

Container release exited with code 1, reason Error
---
info: Using registry public hostname registry.svc.ci.openshift.org
info: Found 77 images in image stream
info: Manifests will be extracted to /tmp/release-image-2018-10-04T184721Z004777864
warning: Could not load current user information: user: unknown userid 1008410000
Unable to connect to the server: net/http: TLS handshake timeout

@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Oct 4, 2018

/retest

last one was probably a flake.

@wking
Copy link
Member

wking commented Oct 4, 2018

At least the unknown userid followed by the TLS timeout have happened before here. And that was last week, so before all the recent craziness ;).

@openshift-merge-robot openshift-merge-robot merged commit 44b2220 into openshift:master Oct 4, 2018
@abhinavdahiya abhinavdahiya mentioned this pull request Oct 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

@crawford crawford Awaiting requested review from crawford

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinavdahiya @wking @openshift-ci-robot @openshift-bot @openshift-merge-robot