Skip to content

Bug 1825418: pkg/destroy/ovirt: Cleanup VM logging #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

Bug 1825418: pkg/destroy/ovirt: Cleanup VM logging #3475

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 17, 2020

This is an automated cherry-pick of #3445

/assign crawford

@wking
pkg/destroy/ovirt: Cleanup VM logging
e80b6c9 
Fixing some of the logging from 0517783 (ovirt: Implement destroy,
2019-10-28, openshift#1948) to avoid things like:

  $ openshift-install destroy cluster --dir one
  INFO searching VMs by tag=one-6xlb7
  INFO Found %!s(int=3) VMs
  INFO Stopping VM one-6xlb7-master-1 : errors: %s%!(EXTRA <nil>)
  ...

because the final 'err' had no %s in the template string to consume
it.  This commit fixes the two cases which had an 'errors: %s' using
up the final template %s, but leaves a lot of other potential logging
cleanup in this package alone.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 17, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] pkg/destroy/ovirt: Cleanup VM logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 17, 2020
Merged
@crawford crawford changed the title [release-4.4] pkg/destroy/ovirt: Cleanup VM logging Bug 1825415: pkg/destroy/ovirt: Cleanup VM logging Apr 17, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/high bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 17, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 17, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1825415, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead
  • expected Bugzilla bug 1825415 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1825415: pkg/destroy/ovirt: Cleanup VM logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford crawford changed the title Bug 1825415: pkg/destroy/ovirt: Cleanup VM logging Bug 1825418: pkg/destroy/ovirt: Cleanup VM logging Apr 17, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 17, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1825418, which is invalid:

  • expected dependent Bugzilla bug 1825415 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1825418: pkg/destroy/ovirt: Cleanup VM logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford
Copy link
Contributor

crawford commented Apr 18, 2020

/bugzilla refresh
/test e2e-ovirt

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2020

@crawford: This pull request references Bugzilla bug 1825418, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1825415 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1825415 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh
/test e2e-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 18, 2020
@sdodson
Copy link
Member

sdodson commented Apr 18, 2020

Reporter, Assignee, and QE for upstream bug 😀
/lgtm
/approve
/test e2e-ovirt

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2020

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt e80b6c9 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 e80b6c9 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-openstack e80b6c9 link /test e2e-openstack
ci/prow/e2e-ovirt e80b6c9 link /test e2e-ovirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Apr 18, 2020

/test e2e-ovirt

@crawford
Copy link
Contributor

crawford commented Apr 18, 2020 •
edited
Loading

There are going to be three PRs that need to be lumped together. I'm just going to do them as one instead of piecemeal.

@crawford crawford closed this Apr 18, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@sdodson sdodson

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @crawford @sdodson @wking