pkg/destroy/ovirt: Cleanup VM logging #3445
Conversation
Fixing some of the logging from 0517783 (ovirt: Implement destroy, 2019-10-28, openshift#1948) to avoid things like: $ openshift-install destroy cluster --dir one INFO searching VMs by tag=one-6xlb7 INFO Found %!s(int=3) VMs INFO Stopping VM one-6xlb7-master-1 : errors: %s%!(EXTRA <nil>) ... because the final 'err' had no %s in the template string to consume it. This commit fixes the two cases which had an 'errors: %s' using up the final template %s, but leaves a lot of other potential logging cleanup in this package alone.
wking
force-pushed
the
ovirt-vm-logging-cleanup
branch
from
ea5ed48 to
d947a58
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Tracked in rhbz#1818529 if folks want something to hang backports on. Not clear to me how far this is worth backporting. |
|
/cherry-pick release-4.4 |
|
@crawford: new pull request created: #3475 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Fixing some of the logging from 0517783 (#1948) to avoid things like:
because the final
errhad no%sin the template string to consume it. This commit fixes the two cases which had anerrors: %susing up the final template%s, but leaves a lot of other potential logging cleanup in this package alone.