Bug 1825418: ovirt: clean up prompts and logging #3480
Conversation
Fixing some of the logging from 0517783 (ovirt: Implement destroy, 2019-10-28, #1948) to avoid things like: $ openshift-install destroy cluster --dir one INFO searching VMs by tag=one-6xlb7 INFO Found %!s(int=3) VMs INFO Stopping VM one-6xlb7-master-1 : errors: %s%!(EXTRA <nil>) ... because the final 'err' had no %s in the template string to consume it. This commit fixes the two cases which had an 'errors: %s' using up the final template %s, but leaves a lot of other potential logging cleanup in this package alone.
This brings the language used in the prompts inline with the style used in the other platforms and adds some more detail to the help messages.
This is a follow-up to d947a58. There were a few incorrect formatting verbs and a few redundant logging statements.
This is a follow-on to 3eccc34. After looking at this more closely, I realized that the cert bundle is only prompted if the CA is trusted locally. This means that if the CA isn't trusted, the communication with the oVirt engine will be insecure. I added a warning to reflect that reality.
|
@crawford: This pull request references Bugzilla bug 1825418, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/high
bugzilla/valid-bug
|
@crawford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| err = uninstaller.removeTemplate(con) | ||
| uninstaller.Logger.Errorf("Removing Template - error: %s", err) | ||
| if err := uninstaller.removeVMs(con); err != nil { | ||
| uninstaller.Logger.Errorf("Failed to remove VMs: %s", err) |
There was a problem hiding this comment.
nit: error message strings should begin with lowercase letters as they are often appended
There was a problem hiding this comment.
I agree (I think), but this isn’t an error string. This is a log line, which I generally capitalize, with the error string embedded (and that string should be lowercase).
There was a problem hiding this comment.
Correct. My mistake!
|
/lgrm |
crawford
added
cherry-pick-approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@crawford: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
No description provided.