gcp upi: enable internal load balancers #3270

jstuever · 2020-03-11T01:58:12Z

This change adds 02_lb_int.py template to the workflow to enable
internal load balancers. The cluster will begin communicating to the api
and mcs through the internal load balancers. The external load balancer
can optionally be disabled for private clusters.

This change also updates the documentation to use the $(command) syntax
to be in line with the other platforms.

In addition, the variable definitions were all moved to immediately
after the associated resources were created. This will help make clear
where their origins are.

Depends on: #2574, openshift/release#7571

abhinavdahiya · 2020-03-11T03:02:59Z

Seems like

installer/data/data/gcp/network/firewall.tf

Line 11 in 5d7730a

source_ranges = [var.public_endpoints ? "0.0.0.0/0" : var.network_cidr]

is missing.

docs/user/gcp/install_upi.md

jstuever · 2020-03-13T00:00:48Z

/cc @patrickdillon
You can focus on the second commit as the first is a different PR.

abhinavdahiya · 2020-03-13T00:26:51Z

461ef60550ec1227bc0cf050bdf97edaba51ffff LGTM

patrickdillon · 2020-03-13T17:20:17Z

I accidentally posted this comment on 3278...
This LGTM. Not sure if we are missing dpeendencies for e2e-gcp-upi but let's give it a shot...

/test e2e-gcp-upi

jstuever · 2020-03-13T18:43:26Z

I need to rebase after #2574 lands, then I'll focus on getting tests to past and reach out for final lgtm and approval.

jstuever · 2020-03-13T19:43:22Z

/test e2e-gcp-upi

jstuever · 2020-03-13T21:07:15Z

/test e2e-gcp-upi

jstuever · 2020-03-14T05:21:16Z

/test e2e-gcp-upi

This change adds 02_lb_int.py template to the workflow to enable internal load balancers. The cluster will begin communicating to the api and mcs through the internal load balancers. The external load balancer can optionally be disabled for private clusters. This change also updates the documentation to use the $(command) syntax to be in line with the other platforms. In addition, the variable definitions were all moved to immediately after the associated resources were created. This will help make clear where their origins are.

jstuever · 2020-03-14T17:55:07Z

/test e2e-gcp-upi

jstuever · 2020-03-14T20:15:30Z

/retest

patrickdillon · 2020-03-16T16:08:38Z

/lgtm

patrickdillon · 2020-03-16T16:10:25Z

/retitle gcp upi: enable internal load balancers

openshift-bot · 2020-03-16T17:29:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T17:55:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T18:21:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T19:52:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T21:23:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T21:35:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T23:19:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T23:33:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-16T23:47:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T00:38:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T01:30:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T01:43:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T02:08:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T02:47:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

abhinavdahiya · 2020-03-17T03:03:35Z

/override ci/prow/e2e-aws

The change is for gcp upi and has no effect at all on e2e-aws

openshift-ci-robot · 2020-03-17T03:04:04Z

@abhinavdahiya: Overrode contexts on behalf of abhinavdahiya: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

The change is for gcp upi and has no effect at all on e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinavdahiya · 2020-03-17T03:05:49Z

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3270/pull-ci-openshift-installer-master-e2e-gcp-upi/34 is already green..

openshift-bot · 2020-03-17T03:52:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T04:58:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T05:13:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T06:15:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T06:28:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T07:34:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T07:46:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T08:12:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-17T09:05:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-17T11:50:50Z

@jstuever: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	`45ccd3f`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jstuever mentioned this pull request Mar 11, 2020

e2e-upi template: gcp enable 02_lb_int.py workflow openshift/release#7571

Merged

jstuever force-pushed the cors1394 branch from 138a321 to 97b512c Compare March 11, 2020 05:50

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 11, 2020

jstuever force-pushed the cors1394 branch 2 times, most recently from 590da29 to 352f7b9 Compare March 11, 2020 17:40

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2020

abhinavdahiya reviewed Mar 11, 2020

View reviewed changes

docs/user/gcp/install_upi.md Outdated Show resolved Hide resolved

This was referenced Mar 11, 2020

GCP UPI: document how to install into a Shared VPC #3278

Merged

e2e-upi template: gcp update 02_lb_int.py workflow openshift/release#7620

Merged

jstuever force-pushed the cors1394 branch 2 times, most recently from 9f2ff90 to 461ef60 Compare March 12, 2020 20:12

openshift-ci-robot requested a review from patrickdillon March 13, 2020 00:00

jstuever force-pushed the cors1394 branch from 461ef60 to 45ccd3f Compare March 14, 2020 17:53

openshift-ci-robot assigned patrickdillon Mar 16, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020

openshift-ci-robot changed the title ~~WIP: gcp upi: enable internal load balancers~~ gcp upi: enable internal load balancers Mar 16, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020

openshift-merge-robot merged commit 4703d61 into openshift:master Mar 17, 2020

jstuever deleted the cors1394 branch June 17, 2020 22:20

gcp upi: enable internal load balancers #3270

gcp upi: enable internal load balancers #3270

Uh oh!

Conversation

jstuever commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhinavdahiya commented Mar 11, 2020

Uh oh!

Uh oh!

jstuever commented Mar 13, 2020

Uh oh!

abhinavdahiya commented Mar 13, 2020

Uh oh!

patrickdillon commented Mar 13, 2020

Uh oh!

jstuever commented Mar 13, 2020

Uh oh!

jstuever commented Mar 13, 2020

Uh oh!

jstuever commented Mar 13, 2020

Uh oh!

jstuever commented Mar 14, 2020

Uh oh!

jstuever commented Mar 14, 2020

Uh oh!

jstuever commented Mar 14, 2020

Uh oh!

patrickdillon commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickdillon commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 16, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

abhinavdahiya commented Mar 17, 2020

Uh oh!

openshift-ci-robot commented Mar 17, 2020

Uh oh!

abhinavdahiya commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

Uh oh!

openshift-bot commented Mar 17, 2020

jstuever commented Mar 11, 2020 •

edited

Loading

patrickdillon commented Mar 16, 2020 •

edited

Loading