gcp upi: split templates to simplify shared vpc workflow. #2574
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
Prior to this change, users needed to edit the gcp upi python templates in order to provision an cluster using a shared VPC. This was prone to user error. This change breaks up the templates so that only the yaml files need to be modified, thus greatly simplifying the process. All of the resources that would be provisioned in the host project are now in their own python templates (01_vpc.py, 02_dns.py, and 03_firewall.py). These resources can be removed from the yaml files to be run against the service project and placed into yaml files to be run against the host project instead.
jstuever
force-pushed
the
gcp_upi_split_templates
branch
from
7f23fe7 to
998a518
Compare
|
/assign @abhinavdahiya |
jstuever
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test e2e-gcp-upi |
|
/retest |
|
/hold for e2e-gcp-upi |
openshift-ci-robot
added
the
do-not-merge/hold
This change is required to assist with the modified GCP UPI workflow defined by openshift/installer#2574.
|
/test e2e-gcp-upi |
1 similar comment
|
/test e2e-gcp-upi |
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| - name: 'w-1' | ||
| type: 06_worker.py | ||
| properties: | ||
| infra_id: '${INFRA_ID}' | ||
| zone: '${ZONE_1}' | ||
| compute_subnet: '${COMPUTE_SUBNET}' | ||
| image: '${CLUSTER_IMAGE}' | ||
| machine_type: 'n1-standard-4' | ||
| root_volume_size: '128' | ||
| service_account_email: '${WORKER_SERVICE_ACCOUNT_EMAIL}' |
There was a problem hiding this comment.
Why the extra worker?
There was a problem hiding this comment.
It's mostly for example of how to do more than one. Though, I believe ingress needed at least 2 at one point in the past. We use 3 in CI.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-upgrade |
|
@abhinavdahiya: Overrode contexts on behalf of abhinavdahiya: ci/prow/e2e-aws-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jstuever: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The consuming script has not been changed since it landed in cbe6f15 (upi/gcp: initial deployment manager templates, 2019-07-29, openshift#2117). The associated Markdown landed with a 'region' in the docs and YAML in cbe6f15. It was removed from the YAML in 998a518 (gcp upi: split templates to simplify shared vpc workflow, 2019-10-25, openshift#2574), but not the surrounding Markdown (until this commit).
7 participants
Prior to this change, users needed to edit the gcp upi python templates
in order to provision an cluster using a shared VPC. This was prone to
user error.
This change breaks up the templates so that only the yaml files need to
be modified, thus greatly simplifying the process. All of the resources
that would be provisioned in the host project are now in their own
python templates (01_vpc.py, 02_dns.py, and 03_firewall.py). These
resources can be removed from the yaml files to be run against the
service project and placed into yaml files to be run against the host
project instead.
requires openshift/release#7540, openshift/release#7571