Add vSphere VIP support #2930

mtnbikenc · 2020-01-15T19:18:50Z

Adds the optional install-config variables for APIVIP, IngressVIP, and DNSVIP to enable IPI deployment.

https://issues.redhat.com/browse/CORS-1317

Needs:

Add vSphere platform status api#541

pkg/asset/manifests/infrastructure.go

Adds the optional install-config variables for APIVIP, IngressVIP, and DNSVIP to enable IPI deployment.

The bump was done using ```$ dep version dep: version : 0.5.1 build date : git hash : go version : go1.12 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false $ dep ensure -update -v github.com/openshift/api ```

jcpowermac · 2020-01-15T23:13:54Z

/approve
/lgtm

sdodson · 2020-01-16T15:00:55Z

pkg/asset/ignition/machine/node.go

 	openstacktypes "github.com/openshift/installer/pkg/types/openstack"
 	openstackdefaults "github.com/openshift/installer/pkg/types/openstack/defaults"
-	"github.com/openshift/installer/pkg/types/ovirt"
+	ovirttypes "github.com/openshift/installer/pkg/types/ovirt"


Intentionally included here?

@rgolangh FYI if so.

I was standardizing the imports to use *types. I can back that out if it is an issue.

lets leave it, just wanted to make sure that it wasn't an oversight

sdodson · 2020-01-16T15:01:21Z

pkg/asset/tls/mcscertkey.go

 	baremetaltypes "github.com/openshift/installer/pkg/types/baremetal"
 	openstacktypes "github.com/openshift/installer/pkg/types/openstack"
 	openstackdefaults "github.com/openshift/installer/pkg/types/openstack/defaults"
+	ovirttypes "github.com/openshift/installer/pkg/types/ovirt"


Intentionally included here?

I was standardizing the imports to use *types. I can back that out if it is an issue.

sdodson · 2020-01-16T15:09:03Z

/approve

openshift-ci-robot · 2020-01-16T15:10:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-16T15:12:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T15:54:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T16:04:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T16:17:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T16:43:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T16:56:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T17:09:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T17:22:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T17:35:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T17:48:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcpowermac · 2020-01-16T21:27:26Z

level=error msg="Error: ResourceLimitExceeded: Task limit exceeded"

/test e2e-aws-upgrade

openshift-bot · 2020-01-16T21:42:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcpowermac · 2020-01-16T21:48:17Z

/skip

openshift-bot · 2020-01-16T22:21:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcpowermac · 2020-01-16T22:23:41Z

Looks like a lot of AWS issues

level=error msg="Error: Error waiting for AMI (ami-072b03e6046c527e0) to be ready: timeout while waiting for state to become 'available' (last state: 'pending', timeout: 40m0s)"

/test e2e-aws-upgrade

jcpowermac · 2020-01-16T22:24:22Z

/skip

openshift-bot · 2020-01-16T23:39:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-16T23:53:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcpowermac · 2020-01-16T23:55:51Z

/hold

jcpowermac · 2020-01-16T23:56:50Z

Keep getting the same AMI error:

level=error msg="Error: Error waiting for AMI (ami-0ba76cd1f4f3993da) to be ready: timeout while waiting for state to become 'available' (last state: 'pending', timeout: 40m0s)"

jcpowermac · 2020-01-17T00:22:43Z

/hold cancel

openshift-bot · 2020-01-17T00:44:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-17T00:57:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcpowermac · 2020-01-17T01:18:04Z

/hold

jcpowermac · 2020-01-17T13:11:41Z

/hold cancel

jcpowermac · 2020-01-17T13:11:53Z

/test e2e-aws-upgrade

openshift-bot · 2020-01-17T13:18:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-17T13:44:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-17T15:18:07Z

@mtnbikenc: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	`3df5eb8`	link	`/test e2e-libvirt`
ci/prow/e2e-openstack	`3df5eb8`	link	`/test e2e-openstack`
ci/prow/e2e-aws-scaleup-rhel7	`3df5eb8`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs · 2020-01-21T15:33:36Z

This breaks vSphere UPI: generated URL for workers / masters is https://:22623/config/worker.ign :/

This reverts commit dcffc31. openshift#2930 breaks vSphere UPI, since generated worker.ign URLs are invalid

jcpowermac · 2020-01-21T15:58:01Z

pkg/asset/ignition/machine/node.go

-	case ovirt.Name:
+	case ovirttypes.Name:
 		ignitionHost = fmt.Sprintf("%s:22623", installConfig.Ovirt.APIVIP)
+	case vspheretypes.Name:


@mtnbikenc @vrutkovs right here is where ignition is broken. Need to add a check for empty string APIVIP

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2020

openshift-ci-robot requested review from jcpowermac and jstuever January 15, 2020 19:23

mtnbikenc force-pushed the vsphere-ipi-vip branch from 5801224 to 0beef59 Compare January 15, 2020 19:34

jcpowermac reviewed Jan 15, 2020

View reviewed changes

pkg/asset/manifests/infrastructure.go Outdated Show resolved Hide resolved

mtnbikenc added 2 commits January 15, 2020 15:53

Add vSphere VIP support

dcffc31

Adds the optional install-config variables for APIVIP, IngressVIP, and DNSVIP to enable IPI deployment.

mtnbikenc force-pushed the vsphere-ipi-vip branch from 0beef59 to 3df5eb8 Compare January 15, 2020 20:56

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2020

mtnbikenc changed the title ~~[WIP] Add vSphere VIP support~~ Add vSphere VIP support Jan 15, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2020

openshift-ci-robot assigned jcpowermac Jan 15, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020

sdodson reviewed Jan 16, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020

openshift-merge-robot merged commit 65a74ec into openshift:master Jan 17, 2020

vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Jan 21, 2020

Revert "Add vSphere VIP support"

eb8a68e

This reverts commit dcffc31. openshift#2930 breaks vSphere UPI, since generated worker.ign URLs are invalid

vrutkovs mentioned this pull request Jan 21, 2020

[FCOS] Post-Jan20 rebase fixes #2952

Merged

1 task

jcpowermac reviewed Jan 21, 2020

View reviewed changes

mtnbikenc deleted the vsphere-ipi-vip branch January 21, 2020 16:00

mtnbikenc mentioned this pull request Jan 24, 2020

Correct ignitionHost for vSphere UPI #2956

Merged

Add vSphere VIP support #2930

Add vSphere VIP support #2930

Uh oh!

Conversation

mtnbikenc commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jcpowermac commented Jan 15, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdodson commented Jan 16, 2020

Uh oh!

openshift-ci-robot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

openshift-bot commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

jcpowermac commented Jan 17, 2020

Uh oh!

openshift-bot commented Jan 17, 2020

Uh oh!

openshift-bot commented Jan 17, 2020

Uh oh!

jcpowermac commented Jan 17, 2020

Uh oh!

jcpowermac commented Jan 17, 2020

Uh oh!

jcpowermac commented Jan 17, 2020

Uh oh!

openshift-bot commented Jan 17, 2020

Uh oh!

mtnbikenc commented Jan 15, 2020 •

edited

Loading