Skip to content

[FCOS] Post-Jan20 rebase fixes #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Jan 27, 2020
Merged

[FCOS] Post-Jan20 rebase fixes #2952

openshift-merge-robot merged 5 commits into from
Jan 27, 2020

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jan 20, 2020 •
edited
Loading

  • Dockerfile.upi: fix terraform-ignition bin path
  • data/data/rhcos.json -> data/data/rhcos-amd64.json (not sure if the previous version should be kept)
  • Add fcos-approvers group (me and Christian)
  • Fix IgnitionHost in vSphere UPI setup
  • bootstrap: ensure "runc" is used as a podman runtime, as its a bit more stable than crun

TODO:

  • AWS IPI fails with
[   10.567447] ignition[603]: error at $.storage.files.128.mode, line 1 col 319077: path not absolute

[   10.577928] ignition[603]: failed to fetch config: config is not valid

@vrutkovs vrutkovs changed the title Dockerfile.upi: fix terraform-ignition bin path [FCOS] Dockerfile.upi: fix terraform-ignition bin path Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 20, 2020

/cc @LorbusChris

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 20, 2020

/retest

1 similar comment
@LorbusChris
Copy link
Contributor

LorbusChris commented Jan 20, 2020

/retest

@LorbusChris
Copy link
Contributor

LorbusChris commented Jan 20, 2020

This slipped through, thanks for the fix, Vadim!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 20, 2020

/override ci/prow/e2e-vsphere

Would be fixed in a follow-up PR

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2020

@vrutkovs: vrutkovs unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

/override ci/prow/e2e-vsphere

Would be fixed in a follow-up PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs mentioned this pull request Jan 20, 2020
Merged
2 tasks
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2020
@vrutkovs vrutkovs changed the title [FCOS] Dockerfile.upi: fix terraform-ignition bin path [FCOS] Post-Jan20 rebase fixes Jan 20, 2020
@LorbusChris
Copy link
Contributor

LorbusChris commented Jan 20, 2020

@vrutkovs meh, I forgot the commit that added us to OWNERS_ALIASES 🙈

@sdodson
Copy link
Member

sdodson commented Jan 21, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 21, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 21, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 22, 2020

/retest

4 similar comments
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 22, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 22, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 22, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 23, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 23, 2020

/retest

9 similar comments
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 23, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 23, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 24, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 24, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 24, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 26, 2020

/retest

@LorbusChris
Copy link
Contributor

LorbusChris commented Jan 26, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 26, 2020

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 27, 2020

/retest

Vadim Rutkovsky and others added 2 commits January 27, 2020 15:12
boostrap: use runc as a podman runtime
fb03da1 
It appears crun is not yet stable and etcd-signer is getting stuck
@mtnbikenc
Correct ignitionHost for vSphere UPI
10a6394 
Does not set vSphere specific ignitionHost if APIVIP is not provided.
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 27, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2020 •
edited
Loading

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 10a6394 link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Jan 27, 2020

/lgtm
/override ci/prow/e2e-vsphere

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2020

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-vsphere

Details

In response to this:

/lgtm
/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7ca0817 into openshift:fcos Jan 27, 2020
@jomeier
Copy link
Contributor

jomeier commented Jan 27, 2020

Yes 🤟 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@sdodson sdodson

@LorbusChris LorbusChris

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vrutkovs @LorbusChris @openshift-ci-robot @sdodson @jomeier @openshift-merge-robot @mtnbikenc