Correct ignitionHost for vSphere UPI #2956
Conversation
openshift-ci-robot
added
the
size/XS
|
/test e2e-vsphere |
pkg/asset/ignition/machine/node.go
Outdated
There was a problem hiding this comment.
else {
ignitionHost = fmt.Sprintf("api-int.%s:22623", installConfig.ClusterDomain())
}
There was a problem hiding this comment.
How about fallthrough?
There was a problem hiding this comment.
Opted against fallthrough and set default to reduce duplicating code with more else.
There was a problem hiding this comment.
If VIP is an IP, need to future-proof for IPV6? net.JoinHostPort() per #2916
openshift-ci-robot
added
size/S
mtnbikenc
changed the title
mtnbikenc
force-pushed
the
fix-ignitionHost
branch
from
5e17e06 to
1ce61da
Compare
|
/test e2e-vsphere |
Does not set vSphere specific ignitionHost if APIVIP is not provided.
mtnbikenc
force-pushed
the
fix-ignitionHost
branch
from
1ce61da to
33c84ec
Compare
|
/lgtm |
|
The vsphere failure is not related to this. As far as I can tell. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mtnbikenc: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
7 participants
Does not set vSphere specific ignitionHost if APIVIP is not provided.