-
Notifications
You must be signed in to change notification settings - Fork 2.1k
installer: upi-e2e template to enable modified gcp upi workflow. #7540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @patrickdillon |
|
this will fail on release-4.4 or release-4.3 branches, as we use the same temaplate, we need to make sure we don't break older consumers. |
@abhinavdahiya I was thinking the same thing; it took a bit for it to soak and to realize a solution. Updated to allow both cases. |
This change is required to assist with the modified GCP UPI workflow defined by openshift/installer#2574.
|
Passes e2e-gcp-upi rehearsal. Everything is inside an |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jstuever: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jstuever: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change is required to assist with the modified GCP UPI workflow
defined by openshift/installer#2574.