Skip to content

Conversation

@jstuever
Copy link
Contributor

This change is required to assist with the modified GCP UPI workflow
defined by openshift/installer#2574.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2020
@jstuever
Copy link
Contributor Author

/cc @patrickdillon
/assign @abhinavdahiya

@abhinavdahiya
Copy link
Contributor

this will fail on release-4.4 or release-4.3 branches, as we use the same temaplate, we need to make sure we don't break older consumers.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2020
@jstuever
Copy link
Contributor Author

this will fail on release-4.4 or release-4.3 branches, as we use the same temaplate, we need to make sure we don't break older consumers.

@abhinavdahiya I was thinking the same thing; it took a bit for it to soak and to realize a solution. Updated to allow both cases.

This change is required to assist with the modified GCP UPI workflow
defined by openshift/installer#2574.
@jstuever
Copy link
Contributor Author

Passes e2e-gcp-upi rehearsal. Everything is inside an elif [[ "${CLUSTER_TYPE}" == "gcp" ]]; then block.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f8bd8ec into openshift:master Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

@jstuever: Updated the following 3 configmaps:

  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
Details

In response to this:

This change is required to assist with the modified GCP UPI workflow
defined by openshift/installer#2574.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-azure-upi 3a7baf3 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi 3a7baf3 link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere 3a7baf3 link /test pj-rehearse
ci/prow/pj-rehearse 3a7baf3 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever jstuever deleted the cors1393 branch February 11, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants