Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Sep 5, 2019

Most of our docs were bumped in befde3c (#1589), but these v1beta4 references snuck in with 0ec07d0 (#1545) and 0055065 (#1873).

Most of our docs were bumped in befde3c (pkg/types/installconfig:
Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references
snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545)
and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2019
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 71d0376 into openshift:master Sep 6, 2019
@wking wking deleted the vsphere-and-metal-drop-v1beta4 branch September 10, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants