docs: vSphere installation docs #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
crawford
reviewed
Apr 9, 2019
staebler
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
small nits, but largely LGTM 🎆 |
Contributor
Author
|
5930b444a...facfc5393 review feedback addressed |
gpei
reviewed
Apr 11, 2019
Docs for installing on vSphere.
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 5, 2019
Most of our docs were bumped in befde3c (pkg/types/installconfig: Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545) and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Oct 10, 2019
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545). Also a bunch of other broken links and some minor wordsmithing.
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
Most of our docs were bumped in befde3c (pkg/types/installconfig: Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545) and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545). Also a bunch of other broken links and some minor wordsmithing.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jan 10, 2020
It's been vCenter since the property landed in 3e73413 (types/vsphere: simplify vsphere platform, 2019-04-10, openshift#1591). This commit fixes "vcenter" typos from 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545) and a947609 (docs/user: Standardize install-config property documentation, 2019-08-05, openshift#2162).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for installing on vSphere.