Skip to content

pkg/types/installconfig: Bump v1beta4 to v1 #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 19, 2019
Merged

pkg/types/installconfig: Bump v1beta4 to v1 #1589

openshift-merge-robot merged 1 commit into from
Apr 19, 2019

Conversation

@wking
Copy link
Member

@wking wking commented Apr 10, 2019

We're locking ourselves in for stability going forward. Hopefully we got this right ;).

CC @abhinavdahiya, @crawford

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 10, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Apr 10, 2019

/hold
@mstaebler and me were discussing on pruning the install config before we make it v1

Also need to talk with hive team.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2019
@wking
Copy link
Member Author

wking commented Apr 10, 2019

Also need to talk with hive team.

We need them on board before we can drop v1beta3 support, but we don't need that to stabilize on v1, do we?

@crawford
Copy link
Contributor

crawford commented Apr 10, 2019

Actually, it looks like this isn't a strict requirement for Beta 4. We should still go ahead with the planned pruning, but we can go with v1beta5 with the hopes that it will become v1.

@sdodson
Copy link
Member

sdodson commented Apr 17, 2019

Actually, it looks like this isn't a strict requirement for Beta 4. We should still go ahead with the planned pruning, but we can go with v1beta5 with the hopes that it will become v1.

@jwforres @crawford is that still accurate? I thought we were being asked to publish v1.

@wking
pkg/types/installconfig: Bump v1beta4 to v1
befde3c 
We're locking ourselves in for stability going forward.  Hopefully we
got this right ;).
@wking wking force-pushed the install-config-v1 branch from 48952b7 to befde3c Compare April 18, 2019 17:22
@wking
Copy link
Member Author

wking commented Apr 18, 2019

Rebased onto master with 48952b78f -> befde3c (no conflicts).

@jwforres
Copy link
Member

jwforres commented Apr 18, 2019

@sdodson It is not a requirement for beta 4, we need to be on v1 for API freeze which is about getting deployed to Starter

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Apr 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2019
@sdodson
Copy link
Member

sdodson commented Apr 18, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Apr 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9535611 into openshift:master Apr 19, 2019
@wking wking deleted the install-config-v1 branch April 19, 2019 04:34
@abhinavdahiya abhinavdahiya mentioned this pull request Jun 4, 2019
Merged
markmc added a commit to markmc/installer that referenced this pull request Aug 21, 2019
@markmc
docs: use v1 format in install-config examples
278689c 
Since openshift#1589 users should be using v1.
@markmc markmc mentioned this pull request Aug 21, 2019
Closed
markmc added a commit to markmc/dev-scripts that referenced this pull request Aug 21, 2019
@markmc
Move to v1 install-config version
a79eaf9 
As of openshift/installer#1589 the install-config format has been
locked in as the v1 version.
@markmc markmc mentioned this pull request Aug 21, 2019
Merged
wking added a commit to wking/openshift-installer that referenced this pull request Sep 5, 2019
@wking
docs/user: Bump vSphere and metal from v1beta4 to v1
ef483d6 
Most of our docs were bumped in befde3c (pkg/types/installconfig:
Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references
snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545)
and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
@wking wking mentioned this pull request Sep 5, 2019
Merged
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Dec 6, 2019
@wking @jhixson74
docs/user: Bump vSphere and metal from v1beta4 to v1
67ed9de 
Most of our docs were bumped in befde3c (pkg/types/installconfig:
Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references
snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545)
and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@staebler staebler Awaiting requested review from staebler

Assignees

@sdodson sdodson

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wking @abhinavdahiya @crawford @sdodson @jwforres @openshift-ci-robot @openshift-merge-robot