image: fix invalid yum commands in images #2206
Conversation
There’s an incorrect `yum install` command without argument, as well an argument on a new line that hurts readability.
openshift-ci-robot
added
the
size/XS
|
/label platform/baremetal |
|
Still getting: for libvirt and the UPI installer, but this PR does fix the baremetal build. /lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1030/ |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
16 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
openshift-ci-robot
added
size/S
epel isn't needed, and the epel-release and awscli packages aren't actually available to the box, and causing errors now that skip_missing_names_on_install is false.
stbenjam
changed the title
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1031/ |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, stbenjam, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1033/ |
|
@stevekuznetsov found the PR that made these issues fatal: openshift/images#11 |
We need both 'oc' and 'aws' for this script. The upi-installer image has a complicated history with the 'aws' command: * openshift/installer@512f93dd30 (images/installer: add image that can be used to instal UPI platforms, 2019-03-22, master and release-4.0, openshift/installer#1456) added the epel-release and awscli RPMs. * openshift/installer@c7b7863b42 (image: remove unneeded packages, 2019-08-13, master and release-4.2, openshift/installer#2206) removed the epel-release and awscli RPMs, which were no longer avialable. * openshift/installer@665ba44f45 (Add AWS CLI to UPI image, 2020-03-13, master and release-4.5, openshift/installer#3292) installed 'aws' via curl. But that means that today the bundled upi-installer has no 'aws' for 4.4 and earlier, leading to errors like [1]: Gathering console logs for i-04151362d551668fe /bin/bash: line 39: aws: command not found error: failed to execute wrapped command: exit status 1 2020/06/18 23:52:50 Container test in pod e2e-aws-gather-aws-console failed, exit code 1, reason Error on 4.2. With this commit I reference the 4.5 image [2,3], because that has the commands I need, and we don't need anything that's particularly senstive to the command versions. [1]: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/382/pull-ci-openshift-cluster-version-operator-release-4.2-e2e-aws/1273733457419177984 [2]: https://github.com/openshift/ci-tools/blob/97d72735a969f11b210806970d523f1b63297905/pkg/webreg/webreg.go#L933-L946 [3]: https://github.com/openshift/ci-tools/blob/97d72735a969f11b210806970d523f1b63297905/pkg/webreg/webreg.go#L1267-L1279
7 participants
This fixes the failing yum commands in the installer images. It looks like yum's
skip_missing_names_on_installis now False, which errors on invalidyum installcommands. baremetal had an isuse where it had a yum install without arguments, the others were installing various unnecessary and unavailable packages: epel-release, awscli, etc.