Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2019
@abhinavdahiya
Copy link
Contributor Author

@wking
Copy link
Member

wking commented Aug 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ca7794c into openshift:master Aug 12, 2019
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
Details

In response to this:

This reverts commit 9ecdb6a.

The dockerfile is incorrect and causing builds to fail
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/2205/pull-ci-openshift-installer-master-images/5466#0:build-log.txt%3A83

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya abhinavdahiya deleted the revert_4640 branch August 12, 2019 22:58
@stbenjam
Copy link
Member

Could we revert this? openshift/installer#2206 fixes the Dockerfile but upi and libvirt are failing too. I don’t think this was the problem, we’ve been building baremetal images for months with this mistake in the file

@abhinavdahiya
Copy link
Contributor Author

Could we revert this? openshift/installer#2206 fixes the Dockerfile but upi and libvirt are failing too. I don’t think this was the problem, we’ve been building baremetal images for months with this mistake in the file

feel free to revert the revert when openshift/installer#2206 merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants