Skip to content

WIP bootkube: add static pod images to bookube flags #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trown wants to merge 1 commit into from
Closed

WIP bootkube: add static pod images to bookube flags #2025

trown wants to merge 1 commit into from

Conversation

@trown
Copy link

@trown trown commented Jul 17, 2019

These images are used by openstack and KNI in order to set up some
infra services that are not provided in our case. This includes node
level DNS and loadbalancing, as well as keepalived to provide failover
for these services.

This requires the flags to be added in MCO first:
openshift/machine-config-operator#983

The images are used in these MCO PRs:
openshift/machine-config-operator#795
openshift/machine-config-operator#740

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2019
@trown
Copy link
Author

trown commented Jul 17, 2019 •
edited
Loading

/hold

openshift/machine-config-operator#983 has to merge first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@runcom runcom mentioned this pull request Jul 17, 2019
Merged
abhinavdahiya
abhinavdahiya reviewed Jul 17, 2019
View reviewed changes
data/data/bootstrap/files/usr/local/bin/bootkube.sh.template Outdated
Copy link
Contributor

@abhinavdahiya abhinavdahiya Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there not image prefix here in the flag?

Copy link
Author

@trown trown Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the flag structure like the --machine-config-$x-image above.

Copy link
Author

@trown trown Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see you mean the '-image' suffix specifically on baremetal-runtimecfg. I fixed it here and in the mco patch. Thanks!

bcrochet
bcrochet reviewed Jul 17, 2019
View reviewed changes
data/data/bootstrap/files/usr/local/bin/bootkube.sh.template Outdated
Copy link
Member

@bcrochet bcrochet Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baremetal-runtimecfg should have -image appended. That was my fault for putting that in my MCO patch.

Copy link
Author

@trown trown Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep fixed

bootkube: add static pod images to bookube flags
fa17c7b 
These images are used by openstack and KNI in order to set up some
infra services that are not provided in our case. This includes node
level DNS and loadbalancing, as well as keepalived to provide failover
for these services.

This requires the flags to be added in MCO first:
openshift/machine-config-operator#983

The images are used in these MCO PRs:
openshift/machine-config-operator#795
openshift/machine-config-operator#740
@trown trown force-pushed the static-pod-images branch from 02ccb79 to fa17c7b Compare July 17, 2019 19:05
@bcrochet bcrochet mentioned this pull request Jul 17, 2019
Closed
@iamemilio
Copy link

iamemilio commented Jul 17, 2019

/retest

1 similar comment
@trown
Copy link
Author

trown commented Jul 18, 2019

/retest

@trown
Copy link
Author

trown commented Jul 18, 2019

/hold cancel
openshift/machine-config-operator#983 merged

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2019
@markmc
Copy link
Contributor

markmc commented Jul 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 18, 2019

/retest

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 18, 2019

@trown bootkube is failing for me with:

Jul 18 12:19:44 tsedovic-c7f7b-bootstrap bootkube.sh[23138]: F0718 12:19:44.020018       1 image.go:32] error: error: Unknown name requested, could not find keepalived-ipfailover in UpdatePayload

Pretty sure that's why this is all red.

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 18, 2019

Looks like keepalived-ipfailover, mdns-publisher and baremetal-runtimecfg are not in the release image yet (coredns and haproxy-router are):

[root@tsedovic-c7f7b-bootstrap ~]# podman run --rm 0ea86d04e774 image keepalived-ipfailover
F0718 12:26:11.622258       1 image.go:32] error: error: Unknown name requested, could not find keepalived-ipfailover in UpdatePayload
[root@tsedovic-c7f7b-bootstrap ~]# podman run --rm 0ea86d04e774 image mdns-publisher
F0718 12:26:21.758719       1 image.go:32] error: error: Unknown name requested, could not find mdns-publisher in UpdatePayload
[root@tsedovic-c7f7b-bootstrap ~]# podman run --rm 0ea86d04e774 image baremetal-runtimecfg
F0718 12:26:30.422306       1 image.go:32] error: error: Unknown name requested, could not find baremetal-runtimecfg in UpdatePayload

@trown
Copy link
Author

trown commented Jul 18, 2019

@trown bootkube is failing for me with:

Jul 18 12:19:44 tsedovic-c7f7b-bootstrap bootkube.sh[23138]: F0718 12:19:44.020018       1 image.go:32] error: error: Unknown name requested, could not find keepalived-ipfailover in UpdatePayload

Pretty sure that's why this is all red.

Indeed... it looks like that image is not actually in the payload :(

oc adm release info registry.svc.ci.openshift.org/origin/release:4.2 | grep keepalived is empty :(

@trown trown changed the title bootkube: add static pod images to bookube flags WIP bootkube: add static pod images to bookube flags Jul 18, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2019
@iamemilio
Copy link

iamemilio commented Jul 18, 2019

/test e2e-openstack

@trown
Copy link
Author

trown commented Jul 22, 2019

/retest

@trown
Copy link
Author

trown commented Jul 22, 2019

/test e2e-openstack

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 24, 2019

/retest

The images are now present in the release.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2019

@trown: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 fa17c7b link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Jul 26, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 26, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mandre, markmc, trown
To complete the pull request process, please assign steveej
You can assign the PR to them by writing /assign @steveej in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Jul 29, 2019

@tomassedovic is this required if https://github.com/openshift/installer/pull/2075/files merges..?

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 30, 2019

@abhinavdahiya it's not -- those two patches are functionally equivalent.

Since #2075 merged, I'm closing this one.

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2019

@tomassedovic: Closed this PR.

Details

In response to this:

@abhinavdahiya it's not -- those two patches are functionally equivalent.

Since #2075 merged, I'm closing this one.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrejpetras andrejpetras mentioned this pull request Aug 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

2 more reviewers

@bcrochet bcrochet bcrochet left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@markmc markmc

@mandre mandre

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@trown @iamemilio @markmc @tomassedovic @openshift-ci-robot @mandre @abhinavdahiya @bcrochet