openstack: baremetal: Add static pod image flags to bootstrap.go #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
kikisdeliveryservice
approved these changes
Jul 17, 2019
Contributor
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
this is correct step in plumbing these images. will leave to @runcom or @cgwalters to LGTM
openshift-ci-robot
added
the
approved
runcom
reviewed
Jul 17, 2019
Member
|
/approve |
Member
|
/lgtm |
runcom
reviewed
Jul 17, 2019
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
This is a prep patch to make these images available in MCO templates. After this merges, we can merge a patch to the installer which passes these flags. These images are needed by the following PRs: openshift#795 openshift#740
Author
|
/hold cancel this should be good to go now |
openshift-ci-robot
removed
the
do-not-merge/hold
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 17, 2019
These images are used by openstack and KNI in order to set up some infra services that are not provided in our case. This includes node level DNS and loadbalancing, as well as keepalived to provide failover for these services. This requires the flags to be added in MCO first: openshift/machine-config-operator#983 The images are used in these MCO PRs: openshift/machine-config-operator#795 openshift/machine-config-operator#740
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, runcom, trown The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prep patch to make these images available in MCO
templates. After this merges, we can merge a patch to the
installer which passes these flags.
These images are needed by the following PRs:
#795
#740