Pass baremetal infra images to MCO bootstrap #2075
Conversation
openshift-ci-robot
added
the
size/S
|
/label platform/baremetal |
|
Please add a reference to the related issue in your commit message - #2067 |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/923/ |
cybertron
force-pushed
the
mco-bootstrap-images
branch
from
12294ef to
b59d814
Compare
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/926/ |
|
Is this still WIP? I would expect this as part of a patch series that also removes all of the bootstrap assets from the installer. Another helpful reference for this commit would be the change on the MCO side to support these new options. |
In order for the baremetal infra services to use the images from the release, we need to look up the correct image during bootstrap and pass that in to the MCO. The new image parameters were added to MCO in openshift/machine-config-operator#795 Part of the changes for openshift#2067
|
This is no longer WIP as of this morning. We got the master and worker templates sorted out in MCO yesterday and the PR merged today. I'll add a reference to it in the commit message. I didn't include the bootstrap change in this PR because I didn't want to block it on the bootstrap MCO change since we did that separately. If that change merges before this one then I'll go ahead and add the bootstrap changes to this PR. Otherwise we'll submit a followup. |
cybertron
force-pushed
the
mco-bootstrap-images
branch
from
b59d814 to
6158aeb
Compare
|
/lgtm |
|
@abhinavdahiya ready for you to take a look to approve |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/952/ |
|
/test e2e-aws-scaleup-rhel7 |
|
e2e-aws-scaleup-rhel7 is ok to fail, I'm not sure I've actually seen it pass... We just need an approval to get this in. /assign @smarterclayton |
|
/unassign @smarterclayton |
|
Needs reference to the machine-config-operator PR that added these flags. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, bcrochet, cybertron, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
11 participants
In order for the baremetal infra services to use the images from the
release, we need to look up the correct image during bootstrap and
pass that in to the MCO.