Resync from upstream and add namespace flag #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds ConfigDrive zz_generated.deepcopy.go by executing go generate under pkg/apis and fix Makefile to prevent from missing.
add description for clouds.yaml and cloud param.
Also, fixed a typo
v1 is already ready now.
Keystone Port number 35357 is for admin user, cluster api user should use 5000.
Error: failed to find an object with gvk.Gvk{Group:"apps", Version:"v1beta1", Kind:"Deployment"} to apply the patch
this should updatek kustomize
* add output folder option now the generate-yaml.sh hard code generation to out folder this PR adds a option to select other places as output folder * Add test for generate yaml file to avoid further issue recently PR 319 added some change but no test for it then PR 321 have to fix that issue, we need this test to cover the test of generation yaml file.
* update to use release-0.1 cluster-api * Run dep ensure
timeout is hard code and sometimes it's might be need to wait for more than 5 min for instance create in some cloud.
This changes provide security groups removal during cluster deletion if managedSecurityGroups is true in clusterSpec.providerSpec Change-Id: I62002e50ae7c60b7fda38663118f8deabb03ba3c
run 'make unit' locally have those update...
cluster variable might be be nil due to some configuration error so this patch adds a check of cluster status before use it
we are not providing any info about control pane CA key and pem add those info will be confusing to end user and seems add private key info into the status is not that secure..
instance create and delete can be have some events so we can record them and for audit purpose.
This patch fixes event creation.
make TokenTTL configurable through CLI
Update cluster-api from `openshift-4.0-cluster-api-0.0.0-alpha.4` to `openshift-4.2-cluster-api-0.1.0`.
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
kind/api-change
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…and it is problematic in CI
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.