Skip to content

Update feature gates for 4.0 new design #14293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mburke5678 merged 1 commit into from
Apr 10, 2019
Merged

Update feature gates for 4.0 new design #14293

mburke5678 merged 1 commit into from
Apr 10, 2019

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Mar 29, 2019

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2019
@mburke5678 mburke5678 added this to the Future Release milestone Mar 29, 2019
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Mar 29, 2019

The preview will be availble shortly at:

@mburke5678 mburke5678 force-pushed the nodes-feature-gates branch from b69e54e to 606f4b9 Compare April 3, 2019 13:14
sjenning
sjenning reviewed Apr 4, 2019
View reviewed changes
modules/nodes-pods-disabling-features-cluster.adoc Outdated
Copy link

@sjenning sjenning Apr 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything on this line and later needs to be removed from the CR. featureSet is a string field now that is either Default or TechPreviewNoUpgrade. Those correspond to predetermined (by us) lists of a feature gates.

Copy link
Contributor Author

@mburke5678 mburke5678 Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjenning Do you have an updated CR that I can use?

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2019
@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 6, 2019

@rphillips @sjenning Please take a look.

Who is the QE resource who can review this PR?

@rphillips
Copy link
Contributor

rphillips commented Apr 8, 2019

Looks great. lgtm. @sjenning?

@rphillips
Copy link
Contributor

rphillips commented Apr 8, 2019 •
edited
Loading

@mburke5678 after openshift/installer#1546 goes in, the cluster resource will be installed by default:

@sjenning
Copy link

sjenning commented Apr 8, 2019

LGTM

@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 8, 2019

@xingxingxia Hello. Is this a PR that you can review? I think Feature Gates is part of the Master team.

@xingxingxia
Copy link
Contributor

xingxingxia commented Apr 9, 2019

@mburke5678 hello, @weinliu will be reviewing it.

@weinliu
Copy link

weinliu commented Apr 10, 2019

@mburke5678 , I'm done with the review work, the doc LGTM

@mburke5678 mburke5678 force-pushed the nodes-feature-gates branch from 4e4968d to 2f88954 Compare April 10, 2019 15:04
@mburke5678 mburke5678 merged commit eceeaf8 into openshift:enterprise-4.0 Apr 10, 2019
@mburke5678 mburke5678 deleted the nodes-feature-gates branch April 10, 2019 15:07
@markmc markmc mentioned this pull request Apr 25, 2019
Closed
@sunilcio
Copy link

sunilcio commented Apr 26, 2019

Is there a plan to allow users to enable or disable individual feature?

@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 26, 2019

@sunilcio As I understand, there will not be a way to enable individual features for 4.1. It will be all or none. @sjenning please let us know if i have this incorrect.

@rphillips
Copy link
Contributor

rphillips commented Apr 26, 2019

That is correct. A customer will be able to enable "TechPreview' to enable extra features.

@kalexand-rh kalexand-rh mentioned this pull request May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning sjenning left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.1 retest-not-required size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.1 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@mburke5678 @openshift-docs-preview-bot @rphillips @sjenning @xingxingxia @weinliu @sunilcio @vikram-redhat @openshift-ci-robot