Skip to content

Comments

ARO-15229: add e2e tests for image registry capability#5810

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
flavianmissi:e2e-test-capability
Mar 26, 2025
Merged

ARO-15229: add e2e tests for image registry capability#5810
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
flavianmissi:e2e-test-capability

Conversation

@flavianmissi
Copy link
Member

@flavianmissi flavianmissi commented Mar 10, 2025

What this PR does / why we need it:
Adds E2E tests for HostedCluster Capabilities API.

Which issue(s) this PR fixes
Fixes #ARO-15229

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@flavianmissi: This pull request references ARO-15229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Adds E2E tests for HostedCluster Capabilities API.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • [] This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@flavianmissi: This pull request references ARO-15229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Adds E2E tests for HostedCluster Capabilities API.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre March 10, 2025 14:33
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@flavianmissi: This pull request references ARO-15229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Adds E2E tests for HostedCluster Capabilities API.

Which issue(s) this PR fixes
Fixes #ARO-15229

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@flavianmissi: This pull request references ARO-15229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
Adds E2E tests for HostedCluster Capabilities API.

Which issue(s) this PR fixes
Fixes #ARO-15229

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member Author

/test e2e-aws-techpreview

@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release labels Mar 12, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2025
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Mar 13, 2025
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 13, 2025

/retitle ARO-15229: add e2e tests for image registry capability

@openshift-ci openshift-ci bot changed the title WIP: ARO-15229: add e2e tests for image registry capability ARO-15229: add e2e tests for image registry capability Mar 13, 2025
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 13, 2025

For Konflux.
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
@flavianmissi flavianmissi force-pushed the e2e-test-capability branch 2 times, most recently from 19631ac to f486de9 Compare March 13, 2025 09:35
@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Mar 13, 2025
@jparrill
Copy link
Contributor

It doesn't feel related to the changes here though, so I'll retest both and see where that takes things.

Nope, I don't think is related too, we are overloaded in the CI part. Also having the AtLeast(4.19) into your E2E tests, our CI should only execute those tests with that concrete version.

@flavianmissi flavianmissi requested a review from jparrill March 21, 2025 13:35
@flavianmissi flavianmissi force-pushed the e2e-test-capability branch 3 times, most recently from 6f122c5 to 91366ea Compare March 24, 2025 09:43
@flavianmissi
Copy link
Member Author

e2e errors don't look related..
/retest

@flavianmissi
Copy link
Member Author

/retest

@flavianmissi
Copy link
Member Author

for Konflux
/retest-required

@enxebre
Copy link
Member

enxebre commented Mar 25, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
* add e2e tests for image registry capability
* s/DisabledCapabilities/Disabled
* set capabilities to empty by default
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@sjenning
Copy link
Contributor

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-on-pull-request, ci/prow/e2e-aks, ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member Author

This was on hold so we could understand the test failures. Now that we've done that and the issue is solved we can removed the hold and allow it to merge.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2025
@sjenning
Copy link
Contributor

/test verify

@openshift-merge-bot openshift-merge-bot bot merged commit 35af753 into openshift:main Mar 26, 2025
16 of 18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.20.0-202503262140.p0.g35af753.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants