Skip to content

Comments

ARO-14443: Bump hypershift image digest#1563

Merged
geoberle merged 1 commit intomainfrom
bump-hypershiftOperator-imageTag
Apr 2, 2025
Merged

ARO-14443: Bump hypershift image digest#1563
geoberle merged 1 commit intomainfrom
bump-hypershiftOperator-imageTag

Conversation

@jubittajohn
Copy link
Collaborator

@jubittajohn jubittajohn commented Mar 26, 2025

https://issues.redhat.com/browse/ARO-14443

This update to the image digest correlates to openshift/hypershift@26fc3ce which includes previous commits openshift/hypershift#5456 that introduces the concept of capabilities to Hypershift on a limited basis, as described in openshift/enhancements#1729 and openshift/hypershift#5810

@jubittajohn jubittajohn changed the title Bump hypershift image digest ARO-14443 : Bump hypershift image digest Mar 26, 2025
@jubittajohn
Copy link
Collaborator Author

@miguelsorianod @machi1990
(Could you help with reviewing the changes and confirming if this is the right time to merge these changes)
I verified that this bump of the operator works with the current version of CS with the following steps:

  1. Created and deployed a new infrastructure for ARO-HCP with the latest changes.
  2. Included the changes in this PR and redeployed hypershift using make hypershiftoperator.deploy_pipeline.
Screenshot 2025-03-26 at 09 53 36
  1. I pulled down the latest changes for the CS repo and am I on master branch.
  2. Initialized the db schemas and started the CS locally after running make cmds.
  3. Send a cluster creation request without the new capabilities attribute.
  4. The cluster is created successfully.
    Screenshot 2025-03-26 at 11 16 44
  5. Created nodepools in the above created hostedcluster
    Screenshot 2025-03-26 at 11 16 16

@jubittajohn jubittajohn changed the title ARO-14443 : Bump hypershift image digest ARO-14443: Bump hypershift image digest Mar 26, 2025
@geoberle
Copy link
Collaborator

@miguelsorianod @bryan-cox @machi1990 what about the --tech-preview-no-upgrade flag? can we remove this one with this bump?

@machi1990
Copy link
Collaborator

@miguelsorianod @bryan-cox @machi1990 what about the --tech-preview-no-upgrade flag? can we remove this one with this bump?

I think the issue we faced the other time has been fixed in hypershift side. It might be good to test it out though, @jubittajohn fancing doing the same test as #1563 (comment) without the --tech-preview-no-upgrade flag; https://github.com/Azure/ARO-HCP/blob/main/config/config.yaml#L20

@bryan-cox
Copy link

@miguelsorianod @bryan-cox @machi1990 what about the --tech-preview-no-upgrade flag? can we remove this one with this bump?

@geoberle @machi1990 - Yeah you shouldn't need that flag anymore.

@jubittajohn
Copy link
Collaborator Author

jubittajohn commented Mar 27, 2025

@miguelsorianod @bryan-cox @machi1990 what about the --tech-preview-no-upgrade flag? can we remove this one with this bump?

@geoberle @machi1990
As I understand, the --tech-preview-no-upgrade flag will no longer be required only after the this PR commit which was merged two days ago. I have to bump the hypershift operator image up to this commit before removing the flag. But for that, I see no images synced into this ACR repo acm-d/rhtap-hypershift-operator after 20/03/2025 as of the time I am commenting.

cc: @bryan-cox

@geoberle
Copy link
Collaborator

@miguelsorianod @bryan-cox @machi1990 what about the --tech-preview-no-upgrade flag? can we remove this one with this bump?

@geoberle @machi1990 As I understand, the --tech-preview-no-upgrade flag will no longer be required only after the this PR commit which was merged two days ago. I have to bump the hypershift operator image up to this commit before removing the flag. But for that, I see no images synced into this ACR repo acm-d/rhtap-hypershift-operator after 20/03/2025 as of the time I am commenting.

cc: @bryan-cox

there are no new images in the source repo on quay after the date you mentioned, hence nothing to sync to ACR
https://quay.io/repository/acm-d/rhtap-hypershift-operator?tab=tags

@github-actions
Copy link

Please rebase pull request.

@jubittajohn jubittajohn force-pushed the bump-hypershiftOperator-imageTag branch from ef5eb8d to 3a7611d Compare April 1, 2025 05:26
Signed-off-by: jubittajohn <jujohn@redhat.com>
@jubittajohn jubittajohn force-pushed the bump-hypershiftOperator-imageTag branch from 56d3f02 to fabd495 Compare April 1, 2025 06:19
@jubittajohn
Copy link
Collaborator Author

jubittajohn commented Apr 1, 2025

@geoberle @machi1990
Thank you for the reviews on this PR.

A new image digest was available yesterday after 10 days. I have used this image to bump the hypershift operator to include both the commits openshift/hypershift#5456 and openshift/hypershift#5810 and removed the flag and have successfully repeated the steps as here #1563 (comment)
Screenshot 2025-04-01 at 01 52 31
Screenshot 2025-04-01 at 02 16 24
Screenshot 2025-04-01 at 10 36 21

@machi1990
Copy link
Collaborator

Thank you @jubittajohn
lgtm

Copy link
Collaborator

@geoberle geoberle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your thorough testing!

@geoberle geoberle merged commit eea4c0d into main Apr 2, 2025
23 checks passed
@geoberle geoberle deleted the bump-hypershiftOperator-imageTag branch April 2, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants