Skip to content

Comments

ARO-15578: add disable cluster capabilities flag to cluster create cmd#5775

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
flavianmissi:disable-caps-cli
Apr 1, 2025
Merged

ARO-15578: add disable cluster capabilities flag to cluster create cmd#5775
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
flavianmissi:disable-caps-cli

Conversation

@flavianmissi
Copy link
Member

@flavianmissi flavianmissi commented Mar 6, 2025 •
edited by openshift-ci bot
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #ARO-15578

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Mar 6, 2025
@openshift-ci openshift-ci bot requested review from csrwng and rtheis March 6, 2025 10:59
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Mar 6, 2025
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 10, 2025

/test e2e-aks

@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

/retitle ARO-15578: add disable cluster capabilities flag to cluster create cmd

@openshift-ci openshift-ci bot changed the title wip: add disable cluster capabilities flag to cluster create cmd ARO-15578: add disable cluster capabilities flag to cluster create cmd Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references ARO-15578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references ARO-15578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references ARO-15578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #ARO-15578

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references ARO-15578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #ARO-15578

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 12, 2025

/retest

@flavianmissi flavianmissi force-pushed the disable-caps-cli branch 2 times, most recently from db2f864 to 13ca35b Compare March 12, 2025 16:42
@openshift-ci openshift-ci bot added the area/api Indicates the PR includes changes for the API label Mar 12, 2025
jparrill
jparrill suggested changes Mar 13, 2025
View reviewed changes
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 13, 2025

Since #5810 has an API change, I'll put this PR on hold until the other lands. I'll remove the hold once I have rebased.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@flavianmissi flavianmissi force-pushed the disable-caps-cli branch 2 times, most recently from 4c8c589 to 4208782 Compare March 27, 2025 08:45
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 27, 2025

rebased with main and updated naming.

@jparrill PTAL

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
bryan-cox
bryan-cox reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor nit, we should have the why/description in the commit messages per 7. here - https://hypershift.pages.dev/contribute/#prior-to-submitting-a-pull-request.

Not going to hold the PR up for this though.

cmd/cluster/core/create.go
flags.StringVar(&opts.ReleaseStream, "release-stream", opts.ReleaseStream, "The OCP release stream for the cluster (e.g. 4-stable-multi), this flag is ignored if release-image is set")
flags.StringVar(&opts.FeatureSet, "feature-set", opts.FeatureSet, "The predefined feature set to use for the cluster (TechPreviewNoUpgrade or DevPreviewNoUpgrade)")

flags.StringSliceVar(&opts.DisableClusterCapabilities, "disable-cluster-capabilities", nil, "Optional cluster capabilities to disabled. The only currently supported value is ImageRegistry.")
Copy link
Member

@bryan-cox bryan-cox Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really minor nit

Suggested change
flags.StringSliceVar(&opts.DisableClusterCapabilities, "disable-cluster-capabilities", nil, "Optional cluster capabilities to disabled. The only currently supported value is ImageRegistry.")
flags.StringSliceVar(&opts.DisableClusterCapabilities, "disable-cluster-capabilities", nil, "Optional cluster capabilities to be disabled. The only currently supported value is ImageRegistry.")

@bryan-cox
Copy link
Member

bryan-cox commented Mar 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@bryan-cox
Copy link
Member

bryan-cox commented Mar 28, 2025

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@bryan-cox: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aks
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-upgrade-hypershift-operator
  • ci/prow/e2e-kubevirt-aws-ovn-reduced
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-hypershift-main-security
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjenning
Copy link
Contributor

sjenning commented Mar 28, 2025

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-main-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjenning
Copy link
Contributor

sjenning commented Mar 28, 2025

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2025

/retest-required

Remaining retests: 0 against base HEAD f484dd0 and 2 for PR HEAD 5a3fa30 in total

@bryan-cox
Copy link
Member

bryan-cox commented Mar 29, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2025

/retest-required

Remaining retests: 0 against base HEAD cbbfe1d and 1 for PR HEAD 5a3fa30 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2025

/retest-required

Remaining retests: 0 against base HEAD eafea57 and 0 for PR HEAD 5a3fa30 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2025

/hold

Revision 5a3fa30 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2025
@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 31, 2025

test failures look to be flakes.
/test e2e-aks

@flavianmissi
Copy link
Member Author

flavianmissi commented Mar 31, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 26fc3ce and 2 for PR HEAD 5a3fa30 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 782dea3 and 1 for PR HEAD 5a3fa30 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 782dea3 and 2 for PR HEAD 5a3fa30 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

/retest-required

Remaining retests: 0 against base HEAD 616a2fa and 1 for PR HEAD 5a3fa30 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025 •
edited
Loading

@flavianmissi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 5a3fa30 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

/retest-required

Remaining retests: 0 against base HEAD e47024d and 0 for PR HEAD 5a3fa30 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e603b04 into openshift:main Apr 1, 2025
11 of 14 checks passed
@openshift-bot
Copy link

openshift-bot commented Apr 1, 2025

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.20.0-202504011356.p0.ge603b04.assembly.stream.el9.
All builds following this will include this PR.

@flavianmissi flavianmissi mentioned this pull request Apr 2, 2025
Merged
4 tasks
@flavianmissi flavianmissi deleted the disable-caps-cli branch May 7, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning sjenning left review comments

@enxebre enxebre enxebre left review comments

@csrwng csrwng Awaiting requested review from csrwng

@rtheis rtheis Awaiting requested review from rtheis

+2 more reviewers

@jparrill jparrill jparrill requested changes

@bryan-cox bryan-cox bryan-cox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jparrill jparrill

@bryan-cox bryan-cox

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@flavianmissi @openshift-ci-robot @jparrill @sjenning @bryan-cox @openshift-bot @enxebre