Skip to content

OCPBUGS-77602: Support Downward API node name override#99

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
noamasu:UPSTREAM-2277-node-name-override
Mar 4, 2026
Merged

OCPBUGS-77602: Support Downward API node name override#99
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
noamasu:UPSTREAM-2277-node-name-override

Conversation

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@noamasu: This pull request references Jira Issue OCPBUGS-77602, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backports of:

OCPBUGS-77602: Support Downward API node name override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and tsmetana March 3, 2026 01:37
@noamasu noamasu force-pushed the UPSTREAM-2277-node-name-override branch from abfa2e3 to d09ac4d Compare March 3, 2026 01:42
@jsafrane
Copy link
Copy Markdown

jsafrane commented Mar 3, 2026

/retest

PushImageToRegistryFailed ??

@noamasu noamasu force-pushed the UPSTREAM-2277-node-name-override branch 2 times, most recently from cd4132c to b2e9fe5 Compare March 3, 2026 11:58
@noamasu noamasu force-pushed the UPSTREAM-2277-node-name-override branch from b2e9fe5 to 19f4f8f Compare March 3, 2026 12:00
@mpatlasov
Copy link
Copy Markdown

/retest

@mpatlasov
Copy link
Copy Markdown

/test e2e-gcp-csi-manual-oidc

@mpatlasov
Copy link
Copy Markdown

PushImageToRegistryFailed ??

Well-known issue: https://issues.redhat.com/browse/COS-4005

@mpatlasov
Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mpatlasov: This pull request references Jira Issue OCPBUGS-77602, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov
Copy link
Copy Markdown

/test e2e-gcp-csi-manual-oidc

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 4, 2026

@noamasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi-manual-oidc 19f4f8f link false /test e2e-gcp-csi-manual-oidc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mpatlasov
Copy link
Copy Markdown

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, noamasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@jsafrane
Copy link
Copy Markdown

jsafrane commented Mar 4, 2026

/verified by jsafrane

I checked the node label node-restriction.kubernetes.io/gke-volume-attach-limit-override=42 gets reflected in CSINode after the driver restart + the node name is passed to the CSI driver on node as --node-name=jsafrane-3-ptm8p-worker-c-vql8m.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jsafrane: This PR has been marked as verified by jsafrane.

Details

In response to this:

/verified by jsafrane

I checked the node label node-restriction.kubernetes.io/gke-volume-attach-limit-override=42 gets reflected in CSINode after the driver restart + the node name is passed to the CSI driver on node as --node-name=jsafrane-3-ptm8p-worker-c-vql8m.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b428a3f into openshift:master Mar 4, 2026
9 of 10 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@noamasu: Jira Issue Verification Checks: Jira Issue OCPBUGS-77602
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77602 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual cherry-pick of:

then auto cherry-pick of:

OCPBUGS-77602: Support Downward API node name override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants