Skip to content

[release-4.21] OCPBUGS-77494: Pass node name to csi-driver container#173

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-172-to-release-4.21
Mar 4, 2026
Merged

[release-4.21] OCPBUGS-77494: Pass node name to csi-driver container#173
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-172-to-release-4.21

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 27, 2026

This is an automated cherry-pick of #172

/assign mpatlasov

@noamasu
OCPBUGS-77428: Pass node name to csi-driver container
7a37615 
The upstream deploy manifest passes --node-name to the csi-driver container
but the operator's node.yaml was missing it. Without it, the driver uses the
short GCP instance name instead of the node name (FQDN), causing
Node object lookups to fail.

Signed-off-by: Noam Assouline <nassouli@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2026
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 27, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-77428 has been cloned as Jira Issue OCPBUGS-77494. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-77494: Pass node name to csi-driver container

Details

In response to this:

This is an automated cherry-pick of #172

/assign mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana February 27, 2026 21:26
@openshift-ci openshift-ci bot changed the title [release-4.21] OCPBUGS-77428: Pass node name to csi-driver container [release-4.21] OCPBUGS-77494: Pass node name to csi-driver container Feb 27, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 27, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-77494, which is invalid:

  • expected dependent Jira Issue OCPBUGS-77428 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #172

/assign mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 28, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mpatlasov
Copy link
Copy Markdown
Contributor

mpatlasov commented Mar 3, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 3, 2026

@mpatlasov: This pull request references Jira Issue OCPBUGS-77494, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-77428 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77428 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @radeore

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from radeore March 3, 2026 21:34
@mpatlasov
Copy link
Copy Markdown
Contributor

mpatlasov commented Mar 3, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@mpatlasov
Copy link
Copy Markdown
Contributor

mpatlasov commented Mar 4, 2026 •
edited
Loading

/hold
This is only partial fix for the parent customer issue. We have to wait until openshift/gcp-pd-csi-driver#99 merged, then get confirmation that that PR#99 along with this PR really fix customer issue.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Mar 4, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 4, 2026
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Mar 4, 2026 •
edited
Loading

/hold cancel
/verified by jsafrane

I tested together with openshift/gcp-pd-csi-driver#101. I checked the node label node-restriction.kubernetes.io/gke-volume-attach-limit-override=42 gets reflected in CSINode after the driver restart + the node name is passed to the CSI driver on node as --node-name=<node name>

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2026

@jsafrane: This PR has been marked as verified by jsafrane.

Details

In response to this:

/hold cancel
/verified by jsafrane

I tested together with openshift/gcp-pd-csi-driver#101. I checked the node label node-restriction.kubernetes.io/gke-volume-attach-limit-override=42 gets reflected in CSINode after the driver restart + the node name is passed to the CSI driver on node as --node-name=

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane jsafrane mentioned this pull request Mar 4, 2026
Merged
@openshift-merge-bot openshift-merge-bot bot merged commit ddfc0f9 into openshift:release-4.21 Mar 4, 2026
11 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2026

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-77494
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77494 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #172

/assign mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

@radeore radeore Awaiting requested review from radeore

Assignees

@mpatlasov mpatlasov

@chao007 chao007

@duanwei33 duanwei33

@Phaow Phaow

@radeore radeore

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @mpatlasov @jsafrane @chao007 @duanwei33 @Phaow @radeore @noamasu